Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VoxelArea: Fix missing cacheExtent calls in helpers #15657

Merged
merged 2 commits into from
Jan 11, 2025

Conversation

Desour
Copy link
Member

@Desour Desour commented Jan 8, 2025

This has no real world inpact. pad is only used in unittest. intersect only at one place, and it doesn't use extent.

To do

This PR is a Ready for Review.

How to test

luanti --run-unittests --test-module TestVoxelArea

@Desour Desour added Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines Bugfix 🐛 PRs that fix a bug labels Jan 8, 2025
@Desour Desour merged commit 436b391 into luanti-org:master Jan 11, 2025
16 checks passed
@Desour Desour deleted the voxelarea_fix_missing_cacheextent branch January 11, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix 🐛 PRs that fix a bug One approval ✅ ◻️ Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants