-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDL: Use scancodes for keybindings #14964
Draft
y5nw
wants to merge
24
commits into
luanti-org:master
Choose a base branch
from
y5nw:scancode
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+577
−394
Draft
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
4153b13
switch KeyMap to unordered_map
y5nw 59d855a
partial
y5nw b62efdd
add scancode-syntax for keybinding settings
y5nw 19d1fe0
fix Android regression
y5nw 441de9f
Add default settings for SDL
y5nw b5fef68
const std::string_view& -> std::string_view
y5nw 7185266
Apply suggestions from code review
y5nw 0fffc9a
remove unused ostringstream constructions
y5nw 845e47f
replace std::variant::index
y5nw f936481
stricted scancode config syntax checking
y5nw 3cec67e
minor: KeyCode -> Keycode
y5nw 7cad03e
Use scancodes only for SDL
y5nw a3130e4
Use std::variant for scancode to properly handle mouse keys
y5nw fa34acd
convert KEY_OEM_* to SDL scancodes directly
y5nw 5990079
move toKeyEvent implementation into touchcontrols
y5nw 104bc43
reformat default key settings
y5nw c13cca3
Explicitly set entire keymap if it was changed pre-scancode
y5nw f4e9242
fixup setting name
y5nw 34d1949
fixup str_starts_with
y5nw ea2805d
review CIrrDeviceSDL
y5nw d831314
review CIrrDeviceSDL again
y5nw 94713c8
Use scancode hack for non-stub/SDL devices
y5nw a7a3454
annotations
y5nw 2c7a441
minor
y5nw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the u32 type represent an implementation-defined code for the key, is that correct?
please document this better
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct. This is now documentated in 9590be1.