Android: Persistent notification while ingame #13125
Open
+75
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zughy
added
Android
UI/UX
Feature ✨
sfan5
changed the title
rubenwardy
added
Concept approved
|
@srifqi rebase needed |
|
I have rebased this PR to current |
sfan5
added
the
Action / change needed
Zughy
added
Rebase needed
|
@srifqi another rebase |
When tapped, the notification will open the currently running game. The notification is ongoing, i.e. can not be cleared/swiped by the user. Known issue: The notification still exists after removing Minetest from the recent application list while the player is still inside a world/server. Restarting Minetest (or via tapping the notification) will clear it up.
srifqi
force-pushed
the
android_notify
branch
2 times, most recently
from
1dd8b2d to
fab225c
Compare
|
I have rebased this PR to current |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal of the PR
This PR adds a notification for Android player when playing inside a world/server.
How does the PR work?
Notify player before the main game loop and remove notification after the main game loop.
Does it resolve any reported issue?
Yes, this PR tries to fix #13115 (read the alternatives).
Does this relate to a goal in the roadmap?
Probably, this PR tries to fix a reported UX issue.
To do
This PR is Ready for Review.
Known issue: The notification still exists after removing Minetest from the recent application list while the player is still inside a world/server. Restarting Minetest (or via tapping the notification) will clear it up. This issue also exists in other application and seems to be OEM-dependent.
How to test