-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve DX, add failing a11y tests #142
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
note that "a future pr" should add git submodule stuff into the npm scripts |
mark-wiemer
commented
Jan 20, 2025
This was referenced Jan 20, 2025
wsor4035
reviewed
Jan 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems good enough. still supports just plain hugo for base work so im happy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(DX == developer experience)
hugo-bin
topackage.json
depdendencies so users don't have to manually install an arbitrary global versionsort-package-json
to help keeppackage.json
in a consistent order (not enforced yet, considering that out of scope for this PR)Notes
hugo.yaml
to use thepackage.json
version ofhugo-extended
instead of manually fetching that specific version. However, I'm not sure how to test all this, and was getting some CSS issues when I ran thehugo --gc ...
command inhugo.yaml
locally. For now, considering that change out of scope for this PR. Ref Use consistent Hugo version for CI and CD #144hugo-bin
, the upstream ofhugo-extended
, is not the "extended" build of Hugo and thus fails to build the site.hugo-extended
it is :)