Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve DX, add failing a11y tests #142

Merged
merged 10 commits into from
Jan 20, 2025
Merged

Conversation

mark-wiemer
Copy link
Contributor

@mark-wiemer mark-wiemer commented Jan 20, 2025

(DX == developer experience)

  • Add hugo-bin to package.json depdendencies so users don't have to manually install an arbitrary global version
  • Document existing spellcheck tests
  • Add sort-package-json to help keep package.json in a consistent order (not enforced yet, considering that out of scope for this PR)
  • Add failing a11y tests that run on the locally-built version of the site. Fixing the tests will be for a second PR. Ref Standard accessibility checks #72

Notes

  • If this PR is accepted, then we should open an issue to update hugo.yaml to use the package.json version of hugo-extended instead of manually fetching that specific version. However, I'm not sure how to test all this, and was getting some CSS issues when I ran the hugo --gc ... command in hugo.yaml locally. For now, considering that change out of scope for this PR. Ref Use consistent Hugo version for CI and CD #144
  • Note hugo-bin, the upstream of hugo-extended, is not the "extended" build of Hugo and thus fails to build the site. hugo-extended it is :)

@mark-wiemer mark-wiemer mentioned this pull request Jan 20, 2025
@wsor4035
Copy link
Collaborator

note that "a future pr" should add git submodule stuff into the npm scripts

README.md Show resolved Hide resolved
@wsor4035 wsor4035 linked an issue Jan 20, 2025 that may be closed by this pull request
Copy link
Collaborator

@wsor4035 wsor4035 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good enough. still supports just plain hugo for base work so im happy

@wsor4035 wsor4035 merged commit 8b5abbb into luanti-org:master Jan 20, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Hugo as project dependency
2 participants