feat: un async merge

[satler-git]

Summary by CodeRabbit

• Refactor

  • Batching now runs synchronously, simplifying control flow and making launch behavior more predictable and consistent for end-users.

• Tests

  • Test suite updated to reflect the synchronous batching flow, ensuring continued reliability and preserved behavior.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Walkthrough

Converted Batcher.merge from async to sync by removing async from its signature in src/launcher/batcher.rs and updated tests/dummyui.rs to call the synchronous version without .await. Call semantics changed from awaiting a Future to returning a bool directly.

Changes

Cohort / File(s)	Summary
Batcher API change src/launcher/batcher.rs	Changed method signature from pub async fn merge(...) to pub fn merge(...); doc comment updated to refer to a synchronous function; internal implementation unchanged in this diff.
Test caller update tests/dummyui.rs	Removed .await from Batcher::merge call and assigned/handled the returned bool synchronously.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant Test as tests/dummyui.rs
  participant Batcher as src/launcher/batcher.rs

  rect rgb(240,255,240)
    Note left of Test: New (synchronous) flow
    Test->>Batcher: merge(buff_a, buff_b)
    Batcher-->>Test: bool (merged?)
  end

  rect rgb(255,245,240)
    Note left of Test: Old (async) flow
    Test->>Batcher: merge(buff_a, buff_b) (returns Future)
    Test->>Test: await future
    Batcher-->>Test: bool (merged?) after await
  end

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• feat: Separate merge into prepare and merge(close #5) #7 — Edits to Batcher::merge in src/launcher/batcher.rs that appear to refactor or change how merge is prepared/executed; strong overlap with this signature change.

Poem

I nibble bytes and tidy queues,
No futures chase, no await to lose.
A synchronous hop, a neat align—
Merge returns true, the logs refine.
🐇

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Title Check	⚠️ Warning	The title “feat: un async merge” is grammatically awkward and does not clearly convey that the pull request converts the Batcher::merge method from asynchronous to synchronous, making it harder for readers to immediately grasp the primary change.	Rename the title to something concise and descriptive such as “Remove async from Batcher::merge method” or “Make Batcher::merge synchronous” so that the main change is clear at a glance.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 394fcdf and 190904a.

📒 Files selected for processing (2)

• src/launcher/batcher.rs (2 hunks)
• tests/dummyui.rs (1 hunks)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[gemini-code-assist]

Summary of Changes

Hello @satler-git, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the merge operation within the batching mechanism to be synchronous. This change ensures that the merge process executes immediately without yielding, aligning with the design intent for it to be a synchronized operation. The corresponding test file has been updated to reflect this change.

Highlights

• Synchronous Merge Operation: The merge function in src/launcher/batcher.rs has been refactored from an asynchronous function to a synchronous one, removing the async keyword from its signature.
• Updated Function Call: The call to batcher.merge in tests/dummyui.rs has been updated to remove the await keyword, reflecting the change to a synchronous merge function.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request simplifies the Batcher by making the merge function synchronous, which aligns with the existing documentation's recommendation for its usage. The change is straightforward and correctly applied in the test suite. I've added one comment regarding a necessary documentation update to keep it consistent with the code changes. Overall, this is a good simplification.

[codspeed-hq]

CodSpeed Performance Report

Merging #27 will not alter performance

_{Comparing push-uvlkysvkmmwo (190904a) with main (0e07770)¹}

Summary

✅ 4 untouched

Footnotes

1. No successful run was found on main (190904a) during the generation of this report, so 0e07770 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩