Skip to content

Fix artifact upload: create archives before uploading to GitHub Release #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lstein merged 2 commits into from
Apr 4, 2026
Merged

Fix artifact upload: create archives before uploading to GitHub Release #215

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
482624d
Fix artifact upload: create archives before uploading to GitHub Release
Copilot Apr 4, 2026
b0cb06c
Use zip archives for all platforms (Linux/macOS/Windows) for consistency
Copilot Apr 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 25 additions & 1 deletion .github/workflows/deploy-pyinstaller.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,16 +16,19 @@ jobs:
build_script: ./INSTALL/pyinstaller/make_pyinstaller_image.sh
executable_ext: ""
macos_app_flag: ""
archive_ext: ".zip"
- os: macos-latest
platform: macos-x64
build_script: ./INSTALL/pyinstaller/make_pyinstaller_image.sh
executable_ext: ""
macos_app_flag: "--macos-app"
archive_ext: ".zip"
- os: windows-latest
platform: windows-x64
build_script: ./INSTALL/pyinstaller/make_pyinstaller_image.ps1
executable_ext: ".exe"
macos_app_flag: ""
archive_ext: ".zip"
exclude:
- os: macos-latest
torch_variant: cu129
Expand Down Expand Up @@ -151,6 +154,27 @@ jobs:
Get-ChildItem *
shell: pwsh

- name: Create archive (Linux/macOS)
if: runner.os != 'Windows'
run: |
VERSION="${{ steps.get_version_unix.outputs.version }}"
ARCHIVE_NAME="photomap-${{ matrix.platform }}-${{ matrix.torch_variant }}-v$VERSION"
cd dist
if [ -d "${ARCHIVE_NAME}.app" ]; then
zip -r "${ARCHIVE_NAME}.zip" "${ARCHIVE_NAME}.app"
else
zip -r "${ARCHIVE_NAME}.zip" "${ARCHIVE_NAME}"
fi
shell: bash

- name: Create archive (Windows)
if: runner.os == 'Windows'
run: |
$version = "${{ steps.get_version_win.outputs.version }}"
$archiveName = "photomap-${{ matrix.platform }}-${{ matrix.torch_variant }}-v$version"
Compress-Archive -Path "dist\$archiveName" -DestinationPath "dist\$archiveName.zip" -Force
shell: pwsh

- name: Debug - List dist contents
run: ls -la dist/
shell: bash
Expand All @@ -165,5 +189,5 @@ jobs:
uses: actions/upload-artifact@v4
with:
name: photomap-${{ matrix.platform }}-${{ matrix.torch_variant }}-v${{ steps.get_version_unix.outputs.version || steps.get_version_win.outputs.version }}
path: dist/photomap-${{ matrix.platform }}-${{ matrix.torch_variant }}-v${{ steps.get_version_unix.outputs.version || steps.get_version_win.outputs.version }}*
path: dist/photomap-${{ matrix.platform }}-${{ matrix.torch_variant }}-v${{ steps.get_version_unix.outputs.version || steps.get_version_win.outputs.version }}${{ matrix.archive_ext }}
retention-days: 30
Loading