get rid of confusing mjd_start in sim_runner #99
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoachim
force-pushed
the
u/yoachim/silly_start
branch
from
db4983b
to
351e5db
Compare
|
Can we use the change from u/neilsen/silly_start instead? The approach on u/yoachim/silly_start breaks stuff in sim archive, and following the approach in u/neilsen/silly_start makes it much easier to update it so it still works, and also avoids overloading the use of mjd_start. |
|
Works for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get rid of confusing kwarg that didn't really work right anyway.