OPSIM-1194: let unscheduled downtimes be less than a day #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| assert ~mo_default.check_up(mjd_down) | ||
| assert mo_ideal.check_up(mjd_down) | ||
| assert ~mo_default.check_up(mjd_down)[0] | ||
| assert mo_ideal.check_up(mjd_down)[0] |
There was a problem hiding this comment.
It would be great to add a test with a short downtime and see that the time returned by check_mjd is the appropriate time, and that if you land in the middle of a day, that it advances to the correct time of sunset.
yoachim
force-pushed
the
tickets/OPSIM-1194
branch
from
2c1219f
to
a1e71c7
Compare
rhiannonlynne
approved these changes
Sep 24, 2024
rhiannonlynne
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
ModelObservatoryso it can handle downtime events that are shorter than 1 day.