DM-47738: Update for refactored meas_extensions_scarlet #405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fred3m
force-pushed
the
tickets/DM-47738
branch
from
f656a08 to
f3a2bf6
Compare
fred3m
force-pushed
the
tickets/DM-47738
branch
from
f3a2bf6 to
c895390
Compare
fred3m
force-pushed
the
tickets/DM-47738
branch
from
8ca10fd to
da52fcb
Compare
taranu
reviewed
Feb 6, 2025
| isDeblendedModelSource = isLeaf & isChild | ||
| fromBlend = isDeblendedModelSource & isSibling | ||
| isIsolatedParent = (depth == 0) & (nPeaks == 1) | ||
| isIsolated = isIsolatedParent | ((depth == 1) & ~isSibling) |
There was a problem hiding this comment.
Shouldn't this generally be depth >= 1?
There was a problem hiding this comment.
No, anything with depth > 1 came from a blend, so by definition it can't be a model of an isolated source. It would be a source that is isolated in the deconvolved frame but not the observed seeing.
|
After a discussion with @TallJimbo we are simplifying the persistence model so that the intermediate parents do not have records in the source catalog, removing the need for this PR, as the main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.