Skip to content

Conversation

@timj
Copy link
Member

@timj timj commented Jul 23, 2020

Nothing works but might be useful to build off.

timj added 2 commits December 30, 2021 10:41
Requires pymysql, MariaDB, and testing.mysqld.

The `replace` tests all fail.

There are some major adjustments of column sizes in butler_attributes
to make it fit.
testCollections still fails.
@codecov
Copy link

codecov bot commented Dec 30, 2021

Codecov Report

Merging #334 (b8c6c1a) into main (9fe239b) will decrease coverage by 0.11%.
The diff coverage is 52.67%.

❗ Current head b8c6c1a differs from pull request most recent head b761109. Consider uploading reports for the commit b761109 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #334      +/-   ##
==========================================
- Coverage   84.14%   84.02%   -0.12%     
==========================================
  Files         237      239       +2     
  Lines       30305    30417     +112     
  Branches     5008     5020      +12     
==========================================
+ Hits        25499    25558      +59     
- Misses       3661     3713      +52     
- Partials     1145     1146       +1     
Impacted Files Coverage Δ
python/lsst/daf/butler/registry/attributes.py 100.00% <ø> (ø)
python/lsst/daf/butler/registry/databases/mysql.py 42.00% <42.00%> (ø)
tests/test_mysql.py 61.29% <61.29%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fe239b...b761109. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants