Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tickets/DM-43403: fix off-axis model for full-array mode and comcam #226

Open
wants to merge 18 commits into
base: develop
Choose a base branch
from

Conversation

jfcrenshaw
Copy link
Collaborator

No description provided.

@jfcrenshaw jfcrenshaw changed the title Tickets/dm 43403 tickets/DM-43403: fix off-axis model for full-array mode and comcam Mar 30, 2024
@jfcrenshaw jfcrenshaw marked this pull request as ready for review April 5, 2024 15:18
Copy link
Member

@jbkalmbach jbkalmbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple small comments. Thanks. Can you hold off on merging until I run a test in the closed loop and make sure everything works and see if there's some improvement as we expect?

python/lsst/ts/wep/task/cutOutDonutsBase.py Outdated Show resolved Hide resolved
python/lsst/ts/wep/task/cutOutDonutsBase.py Outdated Show resolved Hide resolved
python/lsst/ts/wep/task/cutOutDonutsBase.py Outdated Show resolved Hide resolved
@jfcrenshaw
Copy link
Collaborator Author

Rebased on Aug 7th

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants