-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tickets/sitcom 784 #1
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some questions and minor comments, also there are some in the notebooks through the ReviewNB. One general thing I am missing is some kind of conclusion or next steps.
@@ -0,0 +1,1197 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -0,0 +1,1197 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line #31. fig.suptitle(f"{date} - seqNum: {seqNum}")
Maybe something more descriptive here, like M1M3 Hardpoint acceloremeter PSD or Hardpoint VMS PSD
Reply via ReviewNB
notebooks/SITCOMTN_131_M1M3_VMS_TMA_Coupling_investigation_strong_shaking-28-06-2023.ipynb
Show resolved
Hide resolved
notebooks/SITCOMTN_131_M1M3_VMS_TMA_Coupling_investigation_strong_shaking-28-06-2023.ipynb
Show resolved
Hide resolved
notebooks/SITCOMTN_131_M1M3_VMS_TMA_Coupling_investigation_strong_shaking-28-06-2023.ipynb
Show resolved
Hide resolved
notebooks/SITCOMTN_131_M1M3_VMS_TMA_Coupling_investigation_strong_shaking-28-06-2023.ipynb
Show resolved
Hide resolved
Thanks for the review, I think that I addressed all your comment. I also added a general conclusion in the TN saying the following: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks
I need this technote to be reviewed. Please note that there are 2 associated notebooks in the notebooks directory that need to be reviewed too.