Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tickets/sitcom 784 #1

Merged
merged 14 commits into from
Aug 22, 2024
Merged

Tickets/sitcom 784 #1

merged 14 commits into from
Aug 22, 2024

Conversation

boutigny
Copy link
Contributor

@boutigny boutigny commented Aug 8, 2024

I need this technote to be reviewed. Please note that there are 2 associated notebooks in the notebooks directory that need to be reviewed too.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@nsevilla nsevilla self-requested a review August 20, 2024 08:43
Copy link

@nsevilla nsevilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some questions and minor comments, also there are some in the notebooks through the ReviewNB. One general thing I am missing is some kind of conclusion or next steps.

index.rst Outdated Show resolved Hide resolved
index.rst Show resolved Hide resolved
index.rst Outdated Show resolved Hide resolved
index.rst Outdated Show resolved Hide resolved
index.rst Outdated Show resolved Hide resolved
index.rst Outdated Show resolved Hide resolved
index.rst Outdated Show resolved Hide resolved
index.rst Outdated Show resolved Hide resolved
index.rst Outdated Show resolved Hide resolved
index.rst Show resolved Hide resolved
@@ -0,0 +1,1197 @@
{
Copy link

@nsevilla nsevilla Aug 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line #8.            label=f"Accel 2_{axis}",

Accel --> VMS Accel


Reply via ReviewNB

@@ -0,0 +1,1197 @@
{
Copy link

@nsevilla nsevilla Aug 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line #31.    fig.suptitle(f"{date} - seqNum: {seqNum}")

Maybe something more descriptive here, like M1M3 Hardpoint acceloremeter PSD or Hardpoint VMS PSD


Reply via ReviewNB

@boutigny
Copy link
Contributor Author

boutigny commented Aug 21, 2024

Thanks for the review, I think that I addressed all your comment. I also added a general conclusion in the TN saying the following:
In this Technical Note, we have described a detailed investigation of two events where strong vibrations were detected by the VMS system in correlation with other sensors. We have developped the tools (notebooks) to identify and analyse these events and they are ready to be re-used during the next campaign of measurements with the glass mirrors. Unfortunately it was not possible to identify the exact source of these vibrations as the analysis was performed while the cell + surrogate mirror were dismounted. Using these notebooks during the future tests of the TMA will probably allow to identify potential problems and to react quickly.

Copy link

@nsevilla nsevilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks

@boutigny boutigny merged commit c82bff6 into main Aug 22, 2024
2 checks passed
@boutigny boutigny deleted the tickets/SITCOM-784 branch August 22, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants