Skip to content

Conversation

jhoblitt
Copy link
Member

No description provided.

@jhoblitt jhoblitt added the enhancement New feature or request label Apr 25, 2024
Copy link
Contributor

@cbarria cbarria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Great 👍🏻

Copy link
Contributor

@fbegyn fbegyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we might wanna allign all the labels before merging these requests. Alertwise and query wise these seem alright.

Generally we use summary annotations to create a description that is global without any template variables in it, while description annotations will contain specific information about the alert with template variables in it. This allows for a large group of alerts to be grouped together an announced by the summary annotation.

@fbegyn fbegyn force-pushed the IT-5176/certmanagercertificatereadystatus branch from 10c87b5 to 53aa0b1 Compare June 13, 2024 15:41
@jhoblitt jhoblitt force-pushed the IT-5176/certmanagercertificatereadystatus branch from 53aa0b1 to 19a3b58 Compare June 20, 2024 16:01
@jhoblitt jhoblitt force-pushed the IT-5176/certmanagercertificatereadystatus branch from 19a3b58 to 7560bb4 Compare June 20, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants