Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run7/step14 #24

Merged
merged 4 commits into from
Sep 13, 2024
Merged

Run7/step14 #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a44798d
Create dark_shutterOpen.cfg
seanmacb Sep 12, 2024
38caa4f
Create dark_shutterClosed.cfg
seanmacb Sep 12, 2024
da51dbe
Update dark_shutterClosed.cfg
seanmacb Sep 12, 2024
be71d7a
Update dark_shutterOpen.cfg
seanmacb Sep 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions Run7/step14/dark_shutterClosed.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
# 20 15sec DARK images taken with room lights off and Shutter CLOSED
# Before executing this config, make sure shutter is closed. The SHUTTER=None keyword
[ACQUIRE]
dark
[DARK]
BCOUNT=0
dark=15.0 20 # integration time and image count for dark set
SHUTTER=None
Comment on lines +7 to +8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does SHUTTER=None mean? I don't see it used anywhere else in this repo. I do see

SHUTTER  = CLOSE

in Run6/step13/opsimdark.cfg. Based that config, I would have expected the entries here to be

[DARK]
SHUTTER = CLOSE
BCOUNT=0
dark=15.0 20     # integration time and image count for dark set

with the SHUTTER = CLOSE entry before the dark=15.0 20 entry.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explanation on the shutter entries is here.

There is no SHUTTER = CLOSE option supported. That is why I specify the comment at the head of the config file

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is your comment:

 Before executing this config, make sure shutter is closed. The SHUTTER=None keyword

I don't know what "The SHUTTER=None keyword" is supposed to mean. That's why I asked.

7 changes: 7 additions & 0 deletions Run7/step14/dark_shutterOpen.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# 20 15sec DARK images taken with room lights off and Shutter OPEN
[ACQUIRE]
dark
[DARK]
dark=15.0 20 # integration time and image count for dark set
SHUTTER=OPEN
Comment on lines +5 to +6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should SHUTTER = OPEN come before dark=15.0 20?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the parsing of fp-scripts/acquire.py arguments, it should not matter the order of the keywords, so long as they are within the same block. Unless I am misunderstanding something?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just asking a question, if that's ok. If the order doesn't matter, that's fine. I didn't write this code, but there are cases where the order does matter, e.g., in the flat pair acquisitions, so I wanted to ask to be sure. Please ask someone else to review your changes in the future.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for asking a question, and I apologize for not clarifying. I am not trying to be defensive or combative, and I understand that it reads that way. I apologize for my poor choice of words.

I was asking if I was misunderstanding because we have been fairly arbitrary with the ordering of keywords, and I was curious if the order did impact things.

Again, I apologize for being curt. That is not my intention.

BCOUNT=0
Loading