Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Variations with no DarkInterrupt #23

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

jbanovetz
Copy link
Contributor

I added two new files that are just the Persistence_large (Dense Persistence Sequence) and Persistence_short (Single Persistence Sequence) that do not rely on Sean's DarkInterrupt additions, based on what we did in Run6 (see step11 for the template).

@jbanovetz jbanovetz self-assigned this Sep 2, 2024
Copy link
Contributor

@seanmacb seanmacb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Contributor

@jchiang87 jchiang87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you comment why these are needed in addition to the other versions with the DARKINTERRUPT entries? Is it because that functionality isn't available yet from fp-scripts?

@seanmacb
Copy link
Contributor

seanmacb commented Sep 2, 2024

@jchiang87

Dark interrupt has not been tested and verified in fp-scripts
We tested on my fork, and we ran into a buffer read error that would require some dedicated attention
Given the scope of the persistence tests, as well as the limited time until testing startup, this change was deemed necessary

@jbanovetz jbanovetz merged commit 075b9ab into master Sep 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants