Persistence Configs for Run 7 #22
Conversation
There was a problem hiding this comment.
The github actions CI check runs Seth's script as a syntax checker, so you don't need to do that.
I requested a number of changes, the key one being to update the FILTERCONFIG values in all three files.
I'm curious why a flat acquisition is used for Persistence_large.cfg, but sflat for the other two.
Run7/step05/Persistence_large.cfg
Outdated
| [ANALYZE] | ||
| #bias # standalone, build bias Frame | ||
| #noise # needs dark | ||
| #biasnoise # needs bias (noise & noise correlations) | ||
| #dark # needs dark | ||
| #badpixel # needs dark, sflat | ||
| #ptc # needs flatpair | ||
| #brighterfatter # needs flatpair | ||
| #overscan # needs flatpair | ||
| #linearity # needs flat | ||
| #fullwell # needs flat | ||
| #cti # needs sflat | ||
| #tearing # needs sflat | ||
| #persistence # needs persistence | ||
| #scan # needs scan | ||
|
|
||
| [ANALYSIS_RUNS] | ||
| # if only doing a portion of the ACQUIRE, use prior run for GAIN, DARK, BADPIXEL | ||
| #GAIN=curated_amp_gains_2020-09-16.json # get GAIN from this file |
There was a problem hiding this comment.
I think you can just delete the [ANALYZE] and [ANALYSIS_RUNS] sections.
Run7/step05/Persistence_large.cfg
Outdated
| WL =red # wavelength filter to use for the flats | ||
| HILIM =15.0 # maximum seconds for a flat field exposure | ||
| LOLIM =0 # minimum seconds for a flat field exposure | ||
| FILTERCONFIG = /gpfs/slac/lsst/fs2/u1/devel/ccs/bot-eotest-configs/Run6/calib.cfg |
There was a problem hiding this comment.
Please update this path to
FILTERCONFIG = /home/ccs/bot-eotest-configs/Run7/calib.cfg
Run7/step05/Persistence_large.cfg
Outdated
| LOLIM =0 # minimum seconds for a flat field exposure | ||
| FILTERCONFIG = /gpfs/slac/lsst/fs2/u1/devel/ccs/bot-eotest-configs/Run6/calib.cfg | ||
|
|
||
| FLAT=15 90000, # number of electrons/pixel, ND filter |
There was a problem hiding this comment.
This comment, # number of electrons/pixel, ND filter, looks wrong.
Run7/step05/Persistence_large.cfg
Outdated
| 15 170000, | ||
| 15 180000, | ||
| 15 190000, | ||
| 15 200000, |
There was a problem hiding this comment.
Can you add a final \n (newline) to this file?
Run7/step05/Persistence_medium.cfg
Outdated
| DARKINTERRUPT = True # If True, will take darks between flat images | ||
| DARKINTERRUPTLIST = 15 5 # integration time and image count for dark set, formatted the same as the DARK acquisition | ||
| SHUTTER = OPEN # Shutter opens at start of acqusition, closes at end | ||
| FILTERCONFIG = /gpfs/slac/lsst/fs2/u1/devel/ccs/bot-eotest-configs/Run6/calib.cfg |
There was a problem hiding this comment.
This needs to be updated.
Run7/step05/Persistence_short.cfg
Outdated
| DARKINTERRUPT = True # If True, will take darks between flat images | ||
| DARKINTERRUPTLIST = 15 5 # integration time and image count for dark set, formatted the same as the DARK acquisition | ||
| SHUTTER = OPEN # Shutter opens at start of acqusition, closes at end | ||
| FILTERCONFIG = /gpfs/slac/lsst/fs2/u1/devel/ccs/bot-eotest-configs/Run6/calib.cfg |
Run7/step05/Persistence_short.cfg
Outdated
| red 105000 1, # wavelength filter, signal(e-), count | ||
| red 110000 1, # wavelength filter, signal(e-), count | ||
| red 115000 1, # wavelength filter, signal(e-), count | ||
| red 120000 1, # wavelength filter, signal(e-), count |
|
Thank you for looking at it, I will make those changes.
For this one, I wanted two flats taken at the same flux level so that I could average them to beat down any read or shot noise. I could change it to sflats and just copy every flux level X number of times (maybe 3) if that would help with processing. |
|
Looking at the output of Seth's code I don't think that it is picking up the |
|
sure, I don't think the point was to get the timing results though, but rather to do simple syntax checking of the file. |
|
After some discussion in Aaron's weekly meeting, I changed the Large and Short configs to match what he was thinking. This included changing the Large config to |
|
I'd recommend removing the comma at the end of the last line of lists of flats/sflats. I recall that fp_srcipts does not like it. |
|
Removed the commas and will now merge |
Three different Persistence Tests for Run 7. I wasn't able to run Seth's timing code, though I am also not sure if it is set up for the new
DARKINTERRUPTorDARKINTERRUPTLIST, which I rely on for these config files.