Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run7/step11 #14

Merged
merged 6 commits into from
Aug 26, 2024
Merged

Run7/step11 #14

merged 6 commits into from
Aug 26, 2024

Conversation

seanmacb
Copy link
Contributor

@seanmacb seanmacb commented Aug 18, 2024

File structure determined from confluence page

Output from cfg_interp_Run7.py, columns correspond to time in minutes, number of acquisitions, total image volume in TB

|B_Protocol_PTC.cfg                 |    29.4 |   138 |  2.07 |
|Dense_Linear_PTC.cfg               |   192.0 |   900 | 13.50 |
|Dense_Log_PTC.cfg                  |    94.1 |   441 |  6.61 |
|Dense_PTC_blue.cfg                 |   267.5 |  1254 | 18.81 |
|Dense_PTC_nm750.cfg                |   265.0 |  1242 | 18.63 |
|Dense_PTC_nm850.cfg                |   265.0 |  1242 | 18.63 |
|Dense_PTC_nm960.cfg                |   265.0 |  1242 | 18.63 |
|Dense_PTC_red.cfg                  |   265.0 |  1242 | 18.63 |
|Dense_PTC_uv.cfg                   |   265.0 |  1242 | 18.63 |
|Super_Dense_PTC.cfg                |   649.0 |  3042 | 45.63 |```

@seanmacb seanmacb self-assigned this Aug 18, 2024
@seanmacb
Copy link
Contributor Author

Will need new path for FILTERCONFIG

@seanmacb
Copy link
Contributor Author

seanmacb commented Aug 19, 2024

Updated parser results

|B_Protocol_PTC.cfg                 |     0.6 |     3 |  0.04 |
|Dense_Linear_PTC.cfg               |     0.6 |     3 |  0.04 |
|Dense_Log_PTC.cfg                  |     0.6 |     3 |  0.04 |
|Dense_PTC_blue.cfg                 |     0.6 |     3 |  0.04 |
|Dense_PTC_nm750.cfg                |     0.6 |     3 |  0.04 |
|Dense_PTC_nm850.cfg                |     0.6 |     3 |  0.04 |
|Dense_PTC_nm960.cfg                |     0.6 |     3 |  0.04 |
|Dense_PTC_red.cfg                  |     0.6 |     3 |  0.04 |
|Dense_PTC_uv.cfg                   |     0.6 |     3 |  0.04 |
|Super_Dense_PTC.cfg                |     0.6 |     3 |  0.04 |

These do not make a lot of sense, it appears to only be parsing the first entry of each PTC flat config, instead of the full list. I'm guessing this has something to do with the re-ordered flat flux lists, but wonder if it is only for the parser time estimating parser, or would extend to an actual acquisition

@seanmacb
Copy link
Contributor Author

Interestingly, other reordered PTC flat field lists are being parsed correctly

@seanmacb seanmacb force-pushed the run7/step11 branch 4 times, most recently from 495e50d to b9b07b6 Compare August 23, 2024 15:34
Copy link
Contributor

@jchiang87 jchiang87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of the flat acquisition sequences should be randomized.

@seanmacb
Copy link
Contributor Author

One comment from @aaronroodman about the ordering of flat acquisitions:

For step 11 let me suggest the following: there are 2 known effects: temperature dependence in the REBs and persistence following saturated flats. We could avoid both by 1) monotonically increasing flats - to avoid persistence which will only be present when we no longer care and 2) taking 30 minutes or so of 15 second Darks at the beginning to get the system to thermalize.

I can add the dark overhead, but does this sound reasonable @jchiang87 ?

@jchiang87
Copy link
Contributor

sure, sounds fine.

Add step11 in line with BOT EO reverification plan

Modifying PTC files for only flat acquisition, and no bias acquisition at the start of .cfg sequence

Add ordering to flat acquisition

Turn off dark interleaving

Cleaning up files

Removing duplicates in PTC flats

Removing calib.cfg, removing DARKINTERRUPT call

Adding revised FILTERCONFIG path

Removing a calib file that came along for the ride
@seanmacb
Copy link
Contributor Author

Changes made

Copy link
Contributor

@jchiang87 jchiang87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the dark acquisitions are being taken after the flat acquisitions for a number of these .cfg files.

Run7/step11/Dense_Log_PTC.cfg Outdated Show resolved Hide resolved
Run7/step11/Dense_PTC_blue.cfg Outdated Show resolved Hide resolved
Copy link
Contributor

@jchiang87 jchiang87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more file to fix, otherwise looks fine.

Run7/step11/B_Protocol_PTC.cfg Outdated Show resolved Hide resolved
@seanmacb seanmacb merged commit 0dbd63a into master Aug 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants