Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run7/step08 #13

Merged
merged 3 commits into from
Aug 23, 2024
Merged

Run7/step08 #13

merged 3 commits into from
Aug 23, 2024

Conversation

seanmacb
Copy link
Contributor

@seanmacb seanmacb commented Aug 18, 2024

File structure determined from confluence page

Output from cfg_interp_Run7.py, columns correspond to time in minutes, number of acquisitions, total image volume in TB

|B_protocol.cfg                     |    89.3 |   258 |  3.87 |
|B_protocol_excl_light.cfg          |    38.4 |    30 |  0.45 |
|C_protocol.cfg                     |    38.0 |   117 |  1.75 |
|D_protocol.cfg                     |    18.6 |    88 |  1.32 |
|sflat.cfg                          |    12.1 |    45 |  0.67 |
|test_flat.cfg                      |     0.9 |     3 |  0.04 |

@seanmacb seanmacb self-assigned this Aug 18, 2024
@seanmacb
Copy link
Contributor Author

Will need new path for FILTERCONFIG

@seanmacb
Copy link
Contributor Author

Updated results from from cfg_interp_Run7.py

|B_protocol.cfg                     |    59.9 |   120 |  1.80 |
|B_protocol_excl_light.cfg          |    38.4 |    30 |  0.45 |
|C_protocol.cfg                     |    28.4 |    72 |  1.08 |
|D_protocol.cfg                     |     6.4 |    31 |  0.46 |
|sflat.cfg                          |    12.1 |    45 |  0.67 |
|test_flat.cfg                      |     0.9 |     3 |  0.04 |

Copy link
Contributor

@jchiang87 jchiang87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As noted, please update FILTERCONFIG entries and remove Run7/calib.cfg, assuming it's redundant.

@seanmacb seanmacb force-pushed the run7/step08 branch 2 times, most recently from 96f1b46 to 88efd9b Compare August 20, 2024 22:14
Adding step08 in line with BOT EO reverification plan

Removing step02 from git commits

Reordering flat acquisitions to be linear in flux level

Removing dark interrupt

Cleaning up files

Removing duplicate acquisitions in B and D protocol

Removing calib.cfg, removing DARKINTERRUPT call

Adding revised FILTERPATH path
Copy link
Contributor

@jchiang87 jchiang87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The [FLAT] acquisition sequences are all ordered by signal level, but their orders should be randomized.

@seanmacb
Copy link
Contributor Author

From Aaron:

Before I forgot, following up our discussion of this for B sequences - one solution there is to make these monotonically increasing instead of randomized. The randomization is to help separate out other effects (ie temp change) but we mostly understand that now

From me:

Ok, I can make that change with flat acquisitions, reordering the flat acquisitions in ascending flux levels
Should I preserve the older configurations with the flux levels randomized?

From Aaron:

Yes. Suggest that we keep the same config for the inital B sequence run as Run 6, to be able to compare the results as similarly as possible. But then you could make this change for subsequence B protocols.
Although the change in placement of the projector may cause some differences anyway

Copy link
Contributor

@jchiang87 jchiang87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The discussion with Aaron makes sense, so lgtm.

@seanmacb seanmacb merged commit da470d2 into master Aug 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants