Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run7/step02 #12

Merged
merged 2 commits into from
Aug 23, 2024
Merged

Run7/step02 #12

merged 2 commits into from
Aug 23, 2024

Conversation

seanmacb
Copy link
Contributor

@seanmacb seanmacb commented Aug 18, 2024 •
edited
Loading

File structure determined from confluence page

Output from cfg_interp_Run7.py, columns correspond to time in minutes, number of acquisitions, total image volume in terabytes

|B_protocol.cfg                     |    89.3 |   258 |  3.87 |
|B_protocol_excl_light.cfg          |    38.4 |    30 |  0.45 |
|C_protocol.cfg                     |    38.0 |   117 |  1.75 |
|D_protocol.cfg                     |    18.6 |    88 |  1.32 |
|sflat.cfg                          |    12.1 |    45 |  0.67 |
|test_flat.cfg                      |     0.9 |     3 |  0.04 |

@seanmacb seanmacb self-assigned this Aug 18, 2024
@seanmacb seanmacb changed the title Adding step02 in line with BOT EO run plan Run7/step02 Aug 18, 2024
@seanmacb
Copy link
Contributor Author

FILTERCONFIG will need a new path

@seanmacb
Copy link
Contributor Author

Output from cfg_interp_Run7.py unchanged

jchiang87
jchiang87 requested changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@jchiang87 jchiang87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update all of the FILTERCONFIG paths and remove Run7/calib.cfg if it will be the same for all steps.

@seanmacb seanmacb force-pushed the run7/step02 branch 3 times, most recently from dd99b31 to bee9906 Compare August 20, 2024 22:04
jchiang87
jchiang87 requested changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@jchiang87 jchiang87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase to the current master in addition to the items I noted below.

.github/workflows/ci.yaml Outdated Show resolved Hide resolved
Run7/step02/B_protocol.cfg Outdated Show resolved Hide resolved
Run7/step02/C_protocol.cfg Outdated Show resolved Hide resolved
Run7/step02/C_protocol.cfg Outdated Show resolved Hide resolved
Run7/step02/D_protocol.cfg Outdated Show resolved Hide resolved
jchiang87
jchiang87 reviewed Aug 21, 2024
View reviewed changes
Run7/calib.cfg Outdated Show resolved Hide resolved
@seanmacb
Adding step02 in line with BOT EO run plan
bcfa45e 
Adding steps in line with BOT EO Run plan

add ci.yaml

enable manual workflow triggering; syntax fix

Adding step02 in line with BOT EO run plan

Adding steps in line with BOT EO Run plan

Adding step02 in line with BOT EO run plan

Adding steps in line with BOT EO Run plan

Adding step02 in line with BOT EO run plan

Adding steps in line with BOT EO Run plan

Revising comments and duplicates in B, C, and D protocols

Adding step02 in line with BOT EO run plan

Adding steps in line with BOT EO Run plan

add ci.yaml

Adding calib.cfg back
jchiang87
jchiang87 approved these changes Aug 23, 2024
View reviewed changes
Copy link
Contributor

@jchiang87 jchiang87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment, otherwise looks good.

.github/workflows/ci.yaml Show resolved Hide resolved
@seanmacb seanmacb merged commit b434abd into master Aug 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jchiang87 jchiang87 jchiang87 approved these changes

@sethdigel sethdigel Awaiting requested review from sethdigel

Assignees

@seanmacb seanmacb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seanmacb @jchiang87