Fixed misaligned outputs and unicode-width dependency version #1064
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could possibly fix misaligned output issues #1063
The problem occured only if when I
cargo install lsd
, not when I build it directly from the clone or install it viabrew
.This is because of the dependency
unicode-width
's version. The version installed viacargo install
was using the latestunicode-width
, v0.1.13, but others were using v0.1.11 because ofCargo.lock
.The dependency
unicode-width
had a breaking change between v0.1.11 and v0.1.13 that returns a different result when counting unicode characters.The new behavior in
unicode-width
v0.1.13 is more intuitive for calculating the length of a unicode string, so I fixed the logic accordingly.TODO
cargo fmt