fallback to rhino if no default javascript is found .3 (lscproject#280) #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
artlog
commented
Sep 4, 2024
artlog
commented
- avoid NullPointerException even if rhino and js are missing
- avoid NullPointerException even if rhino and js are missing
|
update of #280 after previous review |
|
previous review PR #292 |
abpai94
added a commit
to Worteks/lsc
that referenced
this pull request
Sep 5, 2024
|
@artlog I have pushed the fix to use java 8 compatible Optional code. |
abpai94
added a commit
to Worteks/lsc
that referenced
this pull request
Sep 5, 2024
abpai94
force-pushed
the
208-always-set-default-js.2
branch
from
9ce0c33
to
c9cecfe
Compare
abpai94
force-pushed
the
208-always-set-default-js.2
branch
from
c9cecfe
to
596cb13
Compare
rouazana
approved these changes
Sep 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.