-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use match to get code signing certificates #201
Conversation
…-ios into ci/fastlane-using-match
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for fixing it, this is great :D
No major objections from my side. Technically we can leave out the testing part as we currently don't have any tests, but for the future it makes sense to already have it. Do you have any objections against merging it like this, e.g. testing the TestFlight upload beforehand? The screenshots action we can do in a separate PR
From my side this is fine, yes the screenshots can be a separate PR. Should I merge it or do you want to do it. I would definitely squash it before the merge, as I did quite some messy commits in between. |
Thanks! I will merge it and definitely squash :) |
This PR adds the retrieval of the code signing certificate via Fastlane match.
Certs are stored encrypted in a gitlab repository and managed automatically by Fastlane. The cert is shared by multiple build agents across multiple platforms. For this to be used with GitHub actions a workflow needs to be configured. The necessary environment vars (all prefixed with IOS_) are set as organization secrets. The workflow additionally should export a, for all workflows unique, BUILD_NUMBER. A example workflow for building and releasing from gitlab is linked in this PR.
I also added a new self-hosted runner that needs to be used for the workflow called ls1Agent-mac-2.ase.cit.tum.de with the label "macOS".
Workflow example from GitLab: