Fix answer post got duplicated #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FelberMartin
changed the title
TimOrtel
requested changes
Nov 9, 2024
...rtemis/native_app/feature/metis/conversation/service/storage/impl/MetisStorageServiceImpl.kt
Outdated
Show resolved
Hide resolved
|
Please add unit tests on the level of MetosStorageServiceImpl that verify that this behavior now works correctly. |
julian-wls
reviewed
Nov 9, 2024
...c/main/kotlin/de/tum/informatics/www1/artemis/native_app/feature/metis/shared/db/MetisDao.kt
Show resolved
Hide resolved
...is/native_app/feature/metis/conversation/service/storage/impl/MetisStorageServiceImplTest.kt
Outdated
Show resolved
Hide resolved
TimOrtel
requested changes
Nov 10, 2024
...is/native_app/feature/metis/conversation/service/storage/impl/MetisStorageServiceImplTest.kt
Outdated
Show resolved
Hide resolved
...is/native_app/feature/metis/conversation/service/storage/impl/MetisStorageServiceImplTest.kt
Outdated
Show resolved
Hide resolved
...is/native_app/feature/metis/conversation/service/storage/impl/MetisStorageServiceImplTest.kt
Outdated
Show resolved
Hide resolved
...is/native_app/feature/metis/conversation/service/storage/impl/MetisStorageServiceImplTest.kt
Outdated
Show resolved
Hide resolved
...is/native_app/feature/metis/conversation/service/storage/impl/MetisStorageServiceImplTest.kt
Outdated
Show resolved
Hide resolved
TimOrtel
reviewed
Nov 15, 2024
...metis/conversation/service/storage/impl/MetisStorageServiceImplTestUpgradeLocalAnswerPost.kt
Outdated
Show resolved
Hide resolved
TimOrtel
approved these changes
Nov 19, 2024
|
Before merging, please check the tests. It seems like they have not been executed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From time to time, the Websocket UPDATE event will occur before the
upgradeClientSideAnswerPostmethod was called. This lead to a duplication of the answer post.This is now fixed by removing the older post if necessary.
This closes #92.