Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display content edge-to-edge #91

Merged
merged 14 commits into from
Nov 20, 2024
Merged

Conversation

julian-wls
Copy link
Contributor

Description

This PR introduces edge-to-edge content, which will be enforced with Android 15 (SDK 35).
The changes were made by following the official documentation.
For lazy lists, the content now goes all the way to the edge of the screen leading to the new intended way to display content. Therefore the bottom padding has been replaced with content padding. imePadding has been introduced for items, that normally stick to the end of the screen, but should still be visible, when the ime changes its size.
This PR closes #68.

Testing

The changes have been tested on foldables, tablets and both screen orientations.

Screenshots

Content consumes system bar:
Screenshot2
Content padding to keep content in the safe area:
Screenshot3

@julian-wls julian-wls self-assigned this Nov 7, 2024
Copy link
Collaborator

@FelberMartin FelberMartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done, works in most places. I found a few screens that you probably have missed:

  • When clicking on a lecture, the Lecture Units items are cut off at the bottom of the screen
  • CreateChat: Clicking the FAB and "Create Chat", the info (eg "Please enter at least 3 characters ...") is hidden behind the keyboard

Also, have you tried to adding an UI test that asserts that the ReplyTextField is still visibile after the Keyboard popped up? I am not sure whether compose tests simulate the keyboard, though.
I think we should definetly somehow ensure that the TextField is visible with the Keyboard popping up, as this is like the main usecase for our app.

@julian-wls
Copy link
Contributor Author

  • When clicking on a lecture, the Lecture Units items are cut off at the bottom of the screen
  • CreateChat: Clicking the FAB and "Create Chat", the info (eg "Please enter at least 3 characters ...") is hidden behind the keyboard

Thanks, for pointing that out, I'll go ahead and make the required changes.

Also, have you tried to adding an UI test that asserts that the ReplyTextField is still visibile after the Keyboard popped up? I am not sure whether compose tests simulate the keyboard, though. I think we should definetly somehow ensure that the TextField is visible with the Keyboard popping up, as this is like the main usecase for our app.

That sounds like a really good idea. I'll try to investigate this further and see if I can implement another test class, that adds textfield visibility tests.

Copy link
Collaborator

@FelberMartin FelberMartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm now

@FelberMartin FelberMartin added the ready to merge This PR can be merged label Nov 19, 2024
@FelberMartin FelberMartin merged commit d8cb940 into develop Nov 20, 2024
5 checks passed
@FelberMartin FelberMartin deleted the general/enable-edge-to-edge branch November 20, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge This PR can be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-Enabling EdgeToEdge
2 participants