Improvement: Adjust Favorite Section
#322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FelberMartin
approved these changes
Jan 23, 2025
...otlin/de/tum/informatics/www1/artemis/native_app/feature/metis/shared/ui/ConversationIcon.kt
Outdated
Show resolved
Hide resolved
...otlin/de/tum/informatics/www1/artemis/native_app/feature/metis/shared/ui/ConversationIcon.kt
Outdated
Show resolved
Hide resolved
...is/native_app/feature/metis/manageconversations/ui/conversation/overview/ConversationList.kt
Outdated
Show resolved
Hide resolved
…into improvement/communication/favorite-channel-overview # Conflicts: # feature/metis/manage-conversations/src/main/kotlin/de/tum/informatics/www1/artemis/native_app/feature/metis/manageconversations/ui/conversation/overview/ConversationList.kt # feature/metis/manage-conversations/src/main/kotlin/de/tum/informatics/www1/artemis/native_app/feature/metis/manageconversations/ui/conversation/overview/ConversationOverviewViewModel.kt
julian-wls
approved these changes
Jan 25, 2025
FelberMartin
added
ready to merge
FelberMartin
deleted the
improvement/communication/favorite-channel-overview
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Description
Favorite channels were not easily distinguishable in their original sections, and the behavior was inconsistent with iOS and web platforms, leading to a lack of uniformity across devices.
Web Behavior: Favorite channels are placed at the top of their respective sections.
iOS Behavior: Favorite channels are annotated with an icon in their original section.
This implementation aligns with the iOS pattern by using icons to indicate favorite channels in their original sections.
Changes
Favorite channels are now displayed in both the Favorites section and their original sections.
In the original section, channels marked as favorite are annotated with a heart icon in the bottom-right corner.
Ensures consistency with the iOS design pattern for marking favorite channels.
Steps for testing
Open the Communication Overview screen.
Mark a channel as favorite.
Verify the following:
The channel is visible in both the Favorites section and its original section.
A heart icon appears in the bottom-right corner of the channel in its original section.
Test with multiple channels and ensure the behavior remains consistent.
Verify no heart icon is displayed for channels in the Favorites section.
Screenshots