Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: Increase space below notification settings categories #318

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

julian-wls
Copy link
Contributor

Problem Description

When scrolling to the end of the notification settings, the floating action button to save the changes is placed right above the switch of the last notification category making it hard for users to reach this switch.

Changes

A spacer has been added below the list to increase the padding after the last category. This allows users to reach the switch more easily.

Steps for testing

Scroll to the end of the notification settings and verify that there is enough space now to reach both, the last switch and the floating action button.

Screenshots

Screenshot5

@julian-wls julian-wls added the ready for review This PR can be reviewed label Jan 20, 2025
@julian-wls julian-wls self-assigned this Jan 20, 2025
Copy link
Collaborator

@FelberMartin FelberMartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes lgtm

@FelberMartin FelberMartin added ready to merge This PR can be merged and removed ready for review This PR can be reviewed labels Jan 22, 2025
@FelberMartin FelberMartin merged commit 6d61c44 into develop Jan 22, 2025
5 checks passed
@FelberMartin FelberMartin deleted the improvement/fix-notification-settings-padding branch January 22, 2025 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge This PR can be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants