-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature
: Allow users to undo post deletions
#298
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool change, works as expected. Also tested in offline mode, work as well.
...atics/www1/artemis/native_app/feature/metis/conversation/ui/post/post_actions/PostActions.kt
Outdated
Show resolved
Hide resolved
...in/de/tum/informatics/www1/artemis/native_app/feature/metis/conversation/ui/post/PostItem.kt
Outdated
Show resolved
Hide resolved
...in/de/tum/informatics/www1/artemis/native_app/feature/metis/conversation/ui/post/PostItem.kt
Outdated
Show resolved
Hide resolved
...m/informatics/www1/artemis/native_app/feature/metis/conversation/ui/ConversationViewModel.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look really good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm now!
Communication
: Allow users to undo post deletionsFeature
: Allow users to undo post deletions
…e' into feature/communication/undo-delete
Problem Description
This PR adds the undo delete button known from the web app to the Android app. It is shown 6 seconds to give the user time to undo the post deletion.
Changes
Two lists have been added to the ConversationViewModel, to keep track on posts marked as to be deleted and a list that holds ongoing deletion jobs.
Steps for testing
Screenshots
recording.mp4