Bugfix: Removed moderator rights to edit posts; added test

feature/metis/conversation/src/main/kotlin/de/tum/informatics/www1/artemis/native_app/feature/metis/conversation/ui/post/PostActions.kt

@@ -4,7 +4,6 @@ import androidx.compose.runtime.Composable
 import androidx.compose.runtime.remember
 import androidx.compose.ui.platform.LocalClipboardManager
 import androidx.compose.ui.text.AnnotatedString
-import de.tum.informatics.www1.artemis.native_app.feature.metis.shared.content.dto.IAnswerPost
 import de.tum.informatics.www1.artemis.native_app.feature.metis.shared.content.dto.IBasePost
 
 data class PostActions(
@@ -46,24 +45,24 @@ fun rememberPostActions(
         onRequestRetrySend,
         clipboardManager
     ) {
-        if (post != null) {
-            val doesPostExistOnServer = post.serverPostId != null
-            val hasEditPostRights = hasModerationRights || post.authorId == clientId
-            val hasResolvePostRights = isAtLeastTutorInCourse || post.authorId == clientId
-
-            PostActions(
-                requestEditPost = if (doesPostExistOnServer && hasEditPostRights) onRequestEdit else null,
-                requestDeletePost = if (hasEditPostRights) onRequestDelete else null,
-                onClickReaction = if (doesPostExistOnServer) onClickReaction else null,
-                onCopyText = {
-                    clipboardManager.setText(AnnotatedString(post.content.orEmpty()))
-                },
-                onReplyInThread = if (doesPostExistOnServer) onReplyInThread else null,
-                onResolvePost = if (hasResolvePostRights) onResolvePost else null,
-                onRequestRetrySend = onRequestRetrySend
-            )
-        } else {
-            PostActions()
+        if (post == null) {
+            return@remember PostActions()
         }
+
+        val doesPostExistOnServer = post.serverPostId != null
+        val hasEditPostRights = post.authorId == clientId
+        val hasResolvePostRights = isAtLeastTutorInCourse || post.authorId == clientId
+
+        PostActions(
+            requestEditPost = if (doesPostExistOnServer && hasEditPostRights) onRequestEdit else null,
+            requestDeletePost = if (hasEditPostRights) onRequestDelete else null,
+            onClickReaction = if (doesPostExistOnServer) onClickReaction else null,
+            onCopyText = {
+                clipboardManager.setText(AnnotatedString(post.content.orEmpty()))
+            },
+            onReplyInThread = if (doesPostExistOnServer) onReplyInThread else null,
+            onResolvePost = if (hasResolvePostRights) onResolvePost else null,
+            onRequestRetrySend = onRequestRetrySend
+        )
     }
 }

feature/metis/conversation/src/test/kotlin/de/tum/informatics/www1/artemis/native_app/feature/metis/conversation/ui/post/PostActionsTest.kt

@@ -0,0 +1,76 @@
+package de.tum.informatics.www1.artemis.native_app.feature.metis.conversation.ui.post
+
+import androidx.compose.runtime.Composable
+import androidx.test.ext.junit.runners.AndroidJUnit4
+import de.tum.informatics.www1.artemis.native_app.core.common.test.UnitTest
+import de.tum.informatics.www1.artemis.native_app.core.model.account.User
+import de.tum.informatics.www1.artemis.native_app.core.test.BaseComposeTest
+import de.tum.informatics.www1.artemis.native_app.feature.metis.shared.content.dto.StandalonePost
+import org.junit.Assert.assertEquals
+import org.junit.Assert.assertNotNull
+import org.junit.Assert.assertNull
+import org.junit.Test
+import org.junit.experimental.categories.Category
+import org.junit.runner.RunWith
+
+@Category(UnitTest::class)
+@RunWith(AndroidJUnit4::class)
+class PostActionsTest : BaseComposeTest() {
+
+    private val EDIT_POST = {}
+
+    private val author = User(id = 1)
+    private val instructor = User(id = 2)
+
+    private val post = StandalonePost(
+        id = 1,
+        author = author
+    )
+
+    @Test
+    fun `test GIVEN a post WHEN calling rememberPostActions as the post author THEN onRequestEditPost is not null`() {
+        composeTestRule.setContent {
+            val postActions = createPostActions(
+                editorId = author.id,
+                hasModerationRights = false
+            )
+
+            assertNotNull(postActions.requestEditPost)
+            assertEquals(EDIT_POST, postActions.requestEditPost)
+        }
+    }
+
+
+    @Test
+    fun `test GIVEN a user with moderation-rights WHEN calling rememberPostActions THEN onRequestEditPost is null`() {
+        composeTestRule.setContent {
+            val postActions = createPostActions(
+                editorId = instructor.id,
+                hasModerationRights = true
+            )
+
+            assertNull(postActions.requestEditPost)
+        }
+    }
+
+
+    @Composable
+    private fun createPostActions(
+        editorId: Long,
+        hasModerationRights: Boolean = false,
+    ): PostActions {
+        val postActions = rememberPostActions(
+            post = post,
+            hasModerationRights = hasModerationRights,
+            isAtLeastTutorInCourse = false,
+            clientId = editorId,
+            onRequestEdit = EDIT_POST,
+            onRequestDelete = {},
+            onClickReaction = { _, _ -> },
+            onReplyInThread = {},
+            onResolvePost = {},
+            onRequestRetrySend = {}
+        )
+        return postActions
+    }
+}