-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Communication
: Add ability to pin messenges
#114
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the functionality, works great!
Only thing that I noticed, is that the web app allows users to pin messages in DMs, but this is not possible currently in Android
See code comments below
...in/de/tum/informatics/www1/artemis/native_app/feature/metis/conversation/ui/post/PostItem.kt
Show resolved
Hide resolved
...in/de/tum/informatics/www1/artemis/native_app/feature/metis/conversation/ui/post/PostItem.kt
Outdated
Show resolved
Hide resolved
...in/de/tum/informatics/www1/artemis/native_app/feature/metis/conversation/ui/post/PostItem.kt
Show resolved
Hide resolved
...um/informatics/www1/artemis/native_app/feature/metis/conversation/ui/thread/MetisThreadUi.kt
Outdated
Show resolved
Hide resolved
...informatics/www1/artemis/native_app/feature/metis/conversation/ConversationMessagesUITest.kt
Outdated
Show resolved
Hide resolved
...informatics/www1/artemis/native_app/feature/metis/conversation/ConversationMessagesUITest.kt
Outdated
Show resolved
Hide resolved
.../informatics/www1/artemis/native_app/feature/metis/conversation/ui/chatlist/MetisChatList.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pinning in DMs now also work, nice.
Just update the database version and its good to be merged from my side 👍
app/src/main/java/de/tum/informatics/www1/artemis/native_app/android/db/AppDatabase.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works perfectly over here!
Description
This PR introduces pinning posts. A new post action has been created to allow users to pin standalone posts. Pinning posts is only available for channel creators and moderators, which is why the according flags are passed down to the post action.
With the pinning feature added, it becomes quite clear that the post items in the chat need an overhaul to make the whole view coherent again. This will happen as a follow-up PR as described here.
Changes
Steps for testing
Pin Post
button should be visible.Unpin Post
and verify that the message returns to its initial stateScreenshots