Chore: Re-update to serialization based navigation
#118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julian-wls
approved these changes
Nov 20, 2024
|
Due to a bug in the RobolectricTestRunner I had to ignore the tests using a ModalBottomSheet. This closed dependency update can also be reopened with the ignored tests: #46 |
TimOrtel
reviewed
Nov 27, 2024
app/src/main/java/de/tum/informatics/www1/artemis/native_app/android/ui/MainActivity.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Description
Tim opened #49 that introduced type safe navigation. After prematurely merging the PR, I found that the changes cased a crash. See #49 (comment).
This closes issue #104.
Changes
Readded the changes that Tim already did, and fix two crash causing bugs.
Steps for testing
Navigate through the app and ensure that everything works as expected. Especially cover the case that the user is not logged in when opening the app.
Cover navigation to the following screens: