Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Restructure packages, add workflow run sync + webhook handler #53

Merged
merged 9 commits into from
Dec 2, 2024

Conversation

StefanNemeth
Copy link
Contributor

Description

  • Use Lombok annotation @Log4j2 to avoid boilerplate code
  • Get rid of Git/Github sub-packaging, we plan to use Github only
  • Re-structure packages using package by feature convention
  • Use char array within NATS token config as string is deprecated
  • Fix bug that didn't pass the proper auth token to nats using docker compose
  • Rename RepositoryRepository to GitRepoRepository for clarity reasons
  • Implement workflow run entity, handler for workflow run webhook and sync service

Solves #22

@StefanNemeth StefanNemeth requested a review from a team as a code owner November 24, 2024 20:54
@StefanNemeth StefanNemeth changed the title Restructure packages, add workflow run sync + webhook handler feat: Restructure packages, add workflow run sync + webhook handler Nov 24, 2024
Copy link
Member

@egekocabas egekocabas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works smoothly 👍🏻

We just need to careful about the WorkflowRuns since it might be started with different kind of things such as scheduled, dispatch, etc and they might not be connected with a pull request. The conclusion field is valuable to determine if the run completed or not.

@egekocabas egekocabas merged commit 27b130c into main Dec 2, 2024
4 checks passed
@egekocabas egekocabas deleted the feat/webhook-workflows branch December 2, 2024 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants