Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lectures: Improve and refactor lecture attachment client validation #9893

Open
wants to merge 17 commits into
base: develop
Choose a base branch
from
Open

Lectures: Improve and refactor lecture attachment client validation #9893

wants to merge 17 commits into from
+169 −91

Commits on Nov 28, 2024

  1. Convert attachmentToBeCreated to signal

    @florian-glombik
    florian-glombik committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    17c29af View commit details
    Browse the repository at this point in the history

  2. Convert attachmentFile to signal

    @florian-glombik
    florian-glombik committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    e888a6f View commit details
    Browse the repository at this point in the history

  3. Add visual indicator if fileInput is invalid

    @florian-glombik
    florian-glombik committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    7268f38 View commit details
    Browse the repository at this point in the history

  4. Add form

    @florian-glombik
    florian-glombik committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    c60af2b View commit details
    Browse the repository at this point in the history

  5. Replace ngModel

    @florian-glombik
    florian-glombik committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    4311f8a View commit details
    Browse the repository at this point in the history

  6. Merge table columns

    @florian-glombik
    florian-glombik committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    f9df114 View commit details
    Browse the repository at this point in the history

  7. Use form

    @florian-glombik
    florian-glombik committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    254be49 View commit details
    Browse the repository at this point in the history

  8. Remove outdated validation method

    @florian-glombik
    florian-glombik committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    a641ab3 View commit details
    Browse the repository at this point in the history

  9. Fix tests

    @florian-glombik
    florian-glombik committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    8165b51 View commit details
    Browse the repository at this point in the history

  10. Make sure to use values from form

    @florian-glombik
    florian-glombik committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    0281f22 View commit details
    Browse the repository at this point in the history

  11. Use notification from form and fix test

    @florian-glombik
    florian-glombik committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    d58aab8 View commit details
    Browse the repository at this point in the history

  12. Refactor resetting form

    @florian-glombik
    florian-glombik committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    cb7f5b4 View commit details
    Browse the repository at this point in the history

  13. Reset form values and refactor setLectureAttachment

    @florian-glombik
    florian-glombik committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    db84c69 View commit details
    Browse the repository at this point in the history

  14. Remove duplicated setter

    @florian-glombik
    florian-glombik committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    dd2ce64 View commit details
    Browse the repository at this point in the history

  15. Add form field for attachmentFileName

    @florian-glombik
    florian-glombik committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    ed4f33e View commit details
    Browse the repository at this point in the history

  16. Fix client build issues

    @florian-glombik
    florian-glombik committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    486e152 View commit details
    Browse the repository at this point in the history

  17. Fix upload overwriting the attachment name on first upload

    @florian-glombik
    florian-glombik committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    738dd2b View commit details
    Browse the repository at this point in the history