-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Programming exercises
: Add group feedback feature to feedback analysis table
#9884
Draft
az108
wants to merge
49
commits into
develop
Choose a base branch
from
feature/programming-exercises/add-grouping-feature-to-analysis-table
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Programming exercises
: Add group feedback feature to feedback analysis table
#9884
az108
wants to merge
49
commits into
develop
from
feature/programming-exercises/add-grouping-feature-to-analysis-table
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g-exercises/add-affected-students-to-analysis-table
…d-students-to-analysis-table
…d-affected-students-to-analysis-table' into feature/programming-exercises/add-affected-students-to-analysis-table
…d-students-to-analysis-table
…d-affected-students-to-analysis-table' into feature/programming-exercises/add-affected-students-to-analysis-table
…g-exercises/add-communication-feature-to-analysis-table # Conflicts: # src/main/java/de/tum/cit/aet/artemis/assessment/web/ResultResource.java # src/main/java/de/tum/cit/aet/artemis/exercise/repository/StudentParticipationRepository.java # src/main/webapp/app/exercises/programming/manage/grading/feedback-analysis/feedback-analysis.component.html # src/main/webapp/app/exercises/programming/manage/grading/feedback-analysis/feedback-analysis.component.ts # src/main/webapp/app/exercises/programming/manage/grading/feedback-analysis/feedback-analysis.service.ts # src/main/webapp/i18n/de/programmingExercise.json # src/main/webapp/i18n/en/programmingExercise.json
…g-exercises/add-communication-feature-to-analysis-table
…cation-feature-to-analysis-table
…d-communication-feature-to-analysis-table' into feature/programming-exercises/add-communication-feature-to-analysis-table
…cation-feature-to-analysis-table
…d-communication-feature-to-analysis-table' into feature/programming-exercises/add-communication-feature-to-analysis-table
…cation-feature-to-analysis-table
…d-communication-feature-to-analysis-table' into feature/programming-exercises/add-communication-feature-to-analysis-table
…g-exercises/add-grouping-feature-to-analysis-table # Conflicts: # src/main/java/de/tum/cit/aet/artemis/communication/dto/FeedbackChannelRequestDTO.java # src/main/java/de/tum/cit/aet/artemis/communication/service/conversation/ChannelService.java # src/main/java/de/tum/cit/aet/artemis/communication/web/conversation/ChannelResource.java # src/main/java/de/tum/cit/aet/artemis/exercise/repository/StudentParticipationRepository.java # src/main/webapp/app/exercises/programming/manage/grading/feedback-analysis/Modal/feedback-detail-channel-modal.component.html # src/main/webapp/app/exercises/programming/manage/grading/feedback-analysis/Modal/feedback-detail-channel-modal.component.ts # src/main/webapp/app/exercises/programming/manage/grading/feedback-analysis/feedback-analysis.component.ts # src/main/webapp/app/exercises/programming/manage/grading/feedback-analysis/feedback-analysis.service.ts # src/test/java/de/tum/cit/aet/artemis/communication/ChannelIntegrationTest.java # src/test/javascript/spec/component/programming-exercise/feedback-analysis/feedback-analysis.component.spec.ts # src/test/javascript/spec/component/programming-exercise/feedback-analysis/feedback-analysis.service.spec.ts
github-actions
bot
added
tests
server
Pull requests that update Java code. (Added Automatically!)
client
Pull requests that update TypeScript code. (Added Automatically!)
assessment
Pull requests that affect the corresponding module
communication
Pull requests that affect the corresponding module
exercise
Pull requests that affect the corresponding module
labels
Nov 27, 2024
az108
changed the title
Feature/programming exercises/add grouping feature to analysis table
Nov 27, 2024
Programming exercises
: Add group feedback feature to feedback analysis table
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
assessment
Pull requests that affect the corresponding module
client
Pull requests that update TypeScript code. (Added Automatically!)
communication
Pull requests that affect the corresponding module
exercise
Pull requests that affect the corresponding module
server
Pull requests that update Java code. (Added Automatically!)
tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
General
Server
Client
authorities
to all new routes and checked the course groups for displaying navigation elements (links, buttons).Motivation and Context
This is a follow-up to the feature I’m working on: #9728. The goal is to provide instructors with clearer insights into the feedback given to students. In this PR, a “Feedback Discussion” modal has been introduced. This feature allows instructors to select specific feedback and open a communication channel for it, provided the course has one. For example, during an exam review, instructors can use this functionality to send messages that clarify certain mistakes, offering students a better understanding and clearer insights.
Description
A new server-side query has been implemented, which takes a feedbackDetailText input and creates a channel based on it, automatically adding all students who encountered the corresponding error. On the client side, instructors can now create these channels via a modal accessible on the far-right side of each feedback entry. This modal provides two options: instructors can either navigate directly to the newly created channel or remain on the feedback analysis page. Additionally, the modal allows instructors to specify the channel type, name, and description.
Steps for Testing
Prerequisites:
Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.
Review Progress
Performance Review
Code Review
Manual Tests
Performance Tests
Test Coverage
Screenshots
Before:
After: