-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lectures
: Hide slide pages until a date
#9868
Lectures
: Hide slide pages until a date
#9868
Conversation
d3b1d1d
to
0d228ea
Compare
There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions. |
039e239
to
71f7466
Compare
…f-pages-with-date
…with-date' into feature/lectures/hide-pdf-pages-with-date
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on TS3. I had the same problems as Cathy mentioned
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also tested on TS3 and have no other issues apart from the above ones mentioned by Cathy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran into the same issues as Cathy mentioned.
…hide-pdf-pages-with-date
…with-date' into feature/lectures/hide-pdf-pages-with-date
…hide-pdf-pages-with-date
There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions. |
There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions. |
…f-pages-with-date
Checklist
General
Server
Client
authorities
to all new routes and checked the course groups for displaying navigation elements (links, buttons).Motivation and Context
The feature to hide slide pages (#9667) has been implemented, allowing instructors to hide pages indefinitely. However, a new feature is needed to enable instructors to hide specific pages with more flexibility to enhance functionality. This feature should provide the following options:
1. Hide Indefinitely: Maintain the current functionality to hide pages permanently until manually unhidden.
2. Hide Until a Specific Date: Allow instructors to set a manual date and time for the pages to be automatically unhidden.
3. Hide Until an Exercise's Due Date: Link the hidden pages to an exercise's due date, ensuring they are unhidden when it is due.
Additionally, a scheduled job should be implemented to automatically unhide pages once the specified conditions are met. This enhancement will improve usability and provide greater control for instructors.
Description
To enable the functionality of hiding pages until a specific date, the following changes have been implemented:
1. PDF Preview Date Box Component: A new component named PDF Preview Date Box has been created.
Date Box Accessibility: The Date Box becomes accessible by clicking the "Hide" button when hovering over a page.
2. Hide Options: The Date Box allows instructors to configure hiding options for the selected page. It provides three choices:
3. Configuration View: Once the hiding configuration is saved, the current settings can be viewed by clicking the "View" button.
4. Show Page Popover: In the "Show Page" popover, the selected hiding date is displayed, along with an option to unhide the page.
5. Database Integration: The selected configurations are stored in the Slide table for persistence.
6. Scheduled Job: A scheduled job runs every minute, checking the Slide repository to automatically unhide slides that have reached their specified date.
Steps for Testing
Prerequisites:
Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.
Review Progress
Performance Review
Code Review
Manual Tests
Test Coverage
Screenshots
1. Date Box component with different options selected
2. Show Page popover with different options selected