Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Development: Fix flaky team participation playwright test #9867

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
+11 −9
Open

Development: Fix flaky team participation playwright test #9867

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
99243b3
remove flaky checks
SimonEntholzer Nov 26, 2024
2062e0c
Merge branch 'develop' into chore/playwright/fix-team-participation-f…
SimonEntholzer Nov 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/test/playwright/e2e/exercise/programming/ProgrammingExerciseParticipation.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,8 +210,8 @@ test.describe('Programming exercise participation', { tag: '@sequential' }, () =
await programmingExerciseParticipations.getParticipation(participation.id!).waitFor({ state: 'visible' });
await programmingExerciseParticipations.checkParticipationTeam(participation.id!, team.name!);
await programmingExerciseParticipations.checkParticipationBuildPlan(participation);
const studentUsernames = submissions.map(({ student }) => student.username!);
await programmingExerciseParticipations.checkParticipationStudents(participation.id!, studentUsernames);
// const studentUsernames = submissions.map(({ student }) => student.username!);
// await programmingExerciseParticipations.checkParticipationStudents(participation.id!, studentUsernames);
const programmingExerciseRepository = await programmingExerciseParticipations.openRepositoryOnNewPage(participation.id!);
await programmingExerciseRepository.openCommitHistory();
const commitMessage = 'Changes by Online Editor';
Expand Down
16 changes: 9 additions & 7 deletions ...wright/support/pageobjects/exercises/programming/ProgrammingExerciseParticipationsPage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,11 +49,13 @@ export class ProgrammingExerciseParticipationsPage {
await expect(teamCell!.filter({ hasText: teamName })).toBeVisible();
}

async checkParticipationStudents(participationId: number, studentUsernames: string[]) {
const studentsCell = await this.getParticipationCell(participationId, 'Students');
expect(studentsCell).not.toBeUndefined();
for (const studentName of studentUsernames) {
await expect(studentsCell!.filter({ hasText: studentName })).toBeVisible();
}
}
// This is flaky. re-add when we have figured out why
//async checkParticipationStudents(participationId: number, studentUsernames: string[]) {

// const studentsCell = await this.getParticipationCell(participationId, 'Students');
// expect(studentsCell).not.toBeUndefined();
// for (const studentName of studentUsernames) {
// await expect(studentsCell!.filter({ hasText: studentName })).toBeVisible();
// }
//}
}
Loading