Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development: Migrate text exercises module to standalone on client #9854

Draft
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

FelixTJDietrich
Copy link
Contributor

@FelixTJDietrich FelixTJDietrich commented Nov 25, 2024

Checklist

General

Client

  • Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data (e.g. using paging).
  • I strictly followed the principle of data economy for all client-server REST calls.
  • I strictly followed the client coding and design guidelines.
  • Following the theming guidelines, I specified colors only in the theming variable files and checked that the changes look consistent in both the light and the dark theme.
  • I added multiple integration tests (Jest) related to the features (with a high test coverage), while following the test guidelines.
  • I added authorities to all new routes and checked the course groups for displaying navigation elements (links, buttons).
  • I documented the TypeScript code using JSDoc style.
  • I added multiple screenshots/screencasts of my UI changes.
  • I translated all newly inserted strings into English and German.

Motivation and Context

https://angular.dev/reference/migrations/standalone

Description

Migrates all components and directives of the text exercises module on the client side to use the new standalone mode.

Steps for Testing

Prerequisites:

  • 1 Instructor
  • 1 Students
  • 1 Text exercise

Just check if you notice something strange at each step and check if everything works as expected

  1. Log in to Artemis as Instructor
  2. Navigate to Course Management
  3. -> Select any course
  4. -> Select "Exercises"
  5. "Press Create Text Exercise"
  6. Create a text exercise
  7. Participate in the text exercise
  8. Set due date to be over
  9. Assess the participation
  10. -> Click "Assessment Dashboard" on the exercise detail as instructor
  11. -> Confirm that you understood the instructions
  12. -> Open assessment
  13. -> Give feedback
  14. -> Submit feedback
  15. -> Click "Use as Example Submission"
  16. Go to Assessment Dashboard
  17. Click "Start reading example submissions"
  18. Click "I have read and understood the example"
  19. Go to student view
  20. Click "View submission"

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.







Review Progress

Performance Review

  • I (as a reviewer) confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance even for very large courses with more than 2000 students.
  • I (as a reviewer) confirm that the server changes (in particular related to database calls) are implemented with a very good performance even for very large courses with more than 2000 students.

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

Exam Mode Test

  • Test 1
  • Test 2

Performance Tests

  • Test 1
  • Test 2

Test Coverage

Unchanged

Screenshots

Unchanged

@github-actions github-actions bot added the client Pull requests that update TypeScript code. (Added Automatically!) label Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Pull requests that update TypeScript code. (Added Automatically!) code quality refactoring tests
Projects
Status: Work In Progress
Development

Successfully merging this pull request may close these issues.

1 participant