codeReview Johannes

supporting_scripts/analysis-of-endpoint-connections/src/main/java/de/tum/cit/endpointanalysis/EndpointAnalyzer.java

@@ -124,6 +124,7 @@ private static void printEndpointAnalysisResult() {
         }
         catch (IOException e) {
             logger.error("Failed to deserialize endpoint analysis result", e);
+            return;
         }
 
         endpointsAndMatchingRestCalls.unusedEndpoints().stream().forEach(endpoint -> {

supporting_scripts/analysis-of-endpoint-connections/src/main/java/de/tum/cit/endpointanalysis/EndpointParser.java

@@ -90,7 +90,6 @@ private static void parseServerEndpoints(String[] filePaths) {
                     endpointClasses.add(new EndpointClassInformation(javaClass.getNameAsString(), classRequestMappingString, endpoints));
                 }
             }
-
         }
 
         printFilesFailedToParse(filesFailedToParse);
@@ -111,11 +110,12 @@ private static void parseServerEndpoints(String[] filePaths) {
      * @return a list of EndpointInformation objects representing the extracted endpoint information
      */
     private static List<EndpointInformation> extractAnnotationPathValues(ClassOrInterfaceDeclaration javaClass, Set<String> httpMethodClasses, String classRequestMappingString) {
-        return javaClass.getMethods().stream().flatMap(method -> method.getAnnotations().stream().filter(annotation -> httpMethodClasses.contains(annotation.getNameAsString()))
-                .flatMap(annotation -> extractPathsFromAnnotation(annotation).stream()
-                        .map(path -> new EndpointInformation(classRequestMappingString, method.getNameAsString(), annotation.getNameAsString(), path, javaClass.getNameAsString(),
-                                method.getBegin().get().line, method.getAnnotations().stream().map(AnnotationExpr::toString).collect(Collectors.toList())))))
-                .collect(Collectors.toList());
+        return javaClass.getMethods().stream()
+                .flatMap(method -> method.getAnnotations().stream().filter(annotation -> httpMethodClasses.contains(annotation.getNameAsString()))
+                        .flatMap(annotation -> extractPathsFromAnnotation(annotation).stream()
+                                .map(path -> new EndpointInformation(classRequestMappingString, method.getNameAsString(), annotation.getNameAsString(), path,
+                                        javaClass.getNameAsString(), method.getBegin().get().line, method.getAnnotations().stream().map(AnnotationExpr::toString).toList()))))
+                .toList();
     }
 
     /**