Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stats ordering by Requesttype #389

Merged
merged 1 commit into from
Feb 18, 2025
Merged

Conversation

jfr2102
Copy link
Collaborator

@jfr2102 jfr2102 commented Feb 15, 2025

Fixing the ordering of simulationStats by adding missing request types.
This solves the issue of arbitrary ordered stats at page load

Before:
chrome_HM2zftyav8

After:
chrome_9tAYOYOxq9

To test just open any of your previous runs or create a new benchmark run and then reload the page showing the stats.

@jfr2102 jfr2102 changed the title fix stats ordering by requesttype Fix stats ordering by Requesttype Feb 15, 2025
@jfr2102 jfr2102 marked this pull request as ready for review February 15, 2025 22:27
Copy link
Collaborator

@SimonEntholzer SimonEntholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes total sense 👍

Copy link

@az108 az108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Changes 👍

@jfr2102 jfr2102 merged commit 38f0de1 into main Feb 18, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants