Open
Conversation
Author
|
Packdeps found that clock 0.5.1 has been released, but utc.cabal requires the following bounds:
Is it ok to update it? |
Owner
|
Hi, I'm a little hesitant with the proposed change. The reason I hide the constructors is to make illegal state unrepresentable. If at all, one might consider to export them through an If is too tedious to write for testing it might also be a solution to add an P.S. Thanks for noting the |
Author
|
Yes that makes sense. Thanks for your insight. |
Tested with: - GHC 7.10.3 (stackage lts-5.14) - GHC 7.8.4 (stackage lts-2.19) The IsString instances are kept in a separate module, in order to respect the Safe pragmas.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The data constructors can be useful for testing.