Fix addSecondFractions failing when subtracting whole multiples of 1.0#13
Open
sternenseemann wants to merge 1 commit intolpeterse:masterfrom
Open
Fix addSecondFractions failing when subtracting whole multiples of 1.0#13sternenseemann wants to merge 1 commit intolpeterse:masterfrom
sternenseemann wants to merge 1 commit intolpeterse:masterfrom
Conversation
sternenseemann
force-pushed
the
fix-addSecondFractions
branch
from
1730b0d to
67ae550
Compare
Also adds a test case for this: addSecondFractions (-1.0) should exactly behave like addSeconds (-1). Resolves lpeterse#12.
sternenseemann
force-pushed
the
fix-addSecondFractions
branch
from
67ae550 to
1c9e358
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
frcswas 0 previously, setSecondFraction would be called with1.0which resulted in an error.Resolves #12.