test: prevent binding to the same port in parallel with -threaded#73
Open
sternenseemann wants to merge 1 commit intolpeterse:masterfrom
Open
test: prevent binding to the same port in parallel with -threaded#73sternenseemann wants to merge 1 commit intolpeterse:masterfrom
sternenseemann wants to merge 1 commit intolpeterse:masterfrom
Conversation
|
Since you use |
sternenseemann
force-pushed
the
test-threaded-in-order
branch
from
47d05b4 to
0964a66
Compare
Contributor
Author
|
@Bodigrim right, thanks! Just added some CPP now. |
Bodigrim
approved these changes
Mar 29, 2026
tasty-1.5.4 [1] will execute test cases in parallel when built with -threaded. Since the test suite reuses the same ports constantly, but needs to test e.g. cancel behavior with multiple threads, we need to make sure that we don't try to bind to the same port in parallel. This commit implements the simplest fix for this, by simply adding inOrderTestGroup where necessary. [1]: https://hackage.haskell.org/package/tasty-1.5.4/changelog
sternenseemann
force-pushed
the
test-threaded-in-order
branch
from
0964a66 to
a2687d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tasty-1.5.4 1 will execute test cases in parallel when built with -threaded. Since the test suite reuses the same ports constantly, but needs to test e.g. cancel behavior with multiple threads, we need to make sure that we don't try to bind to the same port in parallel. This commit implements the simplest fix for this, by simply adding inOrderTestGroup where necessary.