Merge pull request #698 from loxilb-io/headless-lb

PR - Support for headless LB rules
loxilb-io · Jun 15, 2024 · 69a84b2 · 69a84b2
2 parents 6918184 + 2475651
commit 69a84b2
Showing 1 changed file with 41 additions and 26 deletions.
diff --git a/pkg/loxinet/rules.go b/pkg/loxinet/rules.go
@@ -1242,17 +1242,22 @@ func (R *RuleH) unFoldRecursiveEPs(r *ruleEnt) {
 // addVIPSys - system specific operations for VIPs of a LB rule
 func (R *RuleH) addVIPSys(r *ruleEnt) {
 	if !strings.Contains(r.name, "ipvs") && !strings.Contains(r.name, "static") {
-		R.vipMap[r.tuples.l3Dst.addr.IP.String()]++
 
-		if R.vipMap[r.tuples.l3Dst.addr.IP.String()] == 1 {
-			R.AdvRuleVIPIfL2(r.tuples.l3Dst.addr.IP)
+		if !r.tuples.l3Dst.addr.IP.IsUnspecified() {
+			R.vipMap[r.tuples.l3Dst.addr.IP.String()]++
+
+			if R.vipMap[r.tuples.l3Dst.addr.IP.String()] == 1 {
+				R.AdvRuleVIPIfL2(r.tuples.l3Dst.addr.IP)
+			}
 		}
 
 		// Take care of any secondary VIPs
 		for _, sVIP := range r.secIP {
-			R.vipMap[sVIP.sIP.String()]++
-			if R.vipMap[sVIP.sIP.String()] == 1 {
-				R.AdvRuleVIPIfL2(sVIP.sIP)
+			if !sVIP.sIP.IsUnspecified() {
+				R.vipMap[sVIP.sIP.String()]++
+				if R.vipMap[sVIP.sIP.String()] == 1 {
+					R.AdvRuleVIPIfL2(sVIP.sIP)
+				}
 			}
 		}
 	}
@@ -1370,6 +1375,11 @@ func (R *RuleH) AddNatLbRule(serv cmn.LbServiceArg, servSecIPs []cmn.LbSecIPArg,
 		return a < b
 	})
 
+	if sNetAddr.IP.IsUnspecified() && serv.Mode != cmn.LBModeHostOneArm {
+		serv.Mode = cmn.LBModeHostOneArm
+		tk.LogIt(tk.LogInfo, "nat lb-rule %s-%v-%s updated to hostOneArm\n", serv.ServIP, serv.ServPort, serv.Proto)
+	}
+
 	natActs.sel = serv.Sel
 	natActs.mode = cmn.LBMode(serv.Mode)
 
@@ -1557,33 +1567,38 @@ func (R *RuleH) AddNatLbRule(serv cmn.LbServiceArg, servSecIPs []cmn.LbSecIPArg,
 // deleteVIPSys - system specific operations for deleting VIPs of a LB rule
 func (R *RuleH) deleteVIPSys(r *ruleEnt) {
 	if !strings.Contains(r.name, "ipvs") && !strings.Contains(r.name, "static") {
-		R.vipMap[r.tuples.l3Dst.addr.IP.String()]--
 
-		if R.vipMap[r.tuples.l3Dst.addr.IP.String()] == 0 {
-			if utils.IsIPHostAddr(r.tuples.l3Dst.addr.IP.String()) {
-				loxinlp.DelAddrNoHook(r.tuples.l3Dst.addr.IP.String()+"/32", "lo")
-			}
-			dev := fmt.Sprintf("llb-rule-%s", r.tuples.l3Dst.addr.IP.String())
-			ret, _ := mh.zr.L3.IfaFind(dev, r.tuples.l3Dst.addr.IP)
-			if ret == 0 {
-				mh.zr.L3.IfaDelete(dev, r.tuples.l3Dst.addr.IP.String()+"/32")
+		if !r.tuples.l3Dst.addr.IP.IsUnspecified() {
+			R.vipMap[r.tuples.l3Dst.addr.IP.String()]--
+
+			if R.vipMap[r.tuples.l3Dst.addr.IP.String()] == 0 {
+				if utils.IsIPHostAddr(r.tuples.l3Dst.addr.IP.String()) {
+					loxinlp.DelAddrNoHook(r.tuples.l3Dst.addr.IP.String()+"/32", "lo")
+				}
+				dev := fmt.Sprintf("llb-rule-%s", r.tuples.l3Dst.addr.IP.String())
+				ret, _ := mh.zr.L3.IfaFind(dev, r.tuples.l3Dst.addr.IP)
+				if ret == 0 {
+					mh.zr.L3.IfaDelete(dev, r.tuples.l3Dst.addr.IP.String()+"/32")
+				}
+				delete(R.vipMap, r.tuples.l3Dst.addr.IP.String())
 			}
-			delete(R.vipMap, r.tuples.l3Dst.addr.IP.String())
 		}
 
 		// Take care of any secondary VIPs
 		for _, sVIP := range r.secIP {
-			R.vipMap[sVIP.sIP.String()]--
-			if R.vipMap[sVIP.sIP.String()] == 0 {
-				if utils.IsIPHostAddr(sVIP.sIP.String()) {
-					loxinlp.DelAddrNoHook(sVIP.sIP.String()+"/32", "lo")
-				}
-				dev := fmt.Sprintf("llb-rule-%s", sVIP.sIP.String())
-				ret, _ := mh.zr.L3.IfaFind(dev, sVIP.sIP)
-				if ret == 0 {
-					mh.zr.L3.IfaDelete(dev, sVIP.sIP.String()+"/32")
+			if !sVIP.sIP.IsUnspecified() {
+				R.vipMap[sVIP.sIP.String()]--
+				if R.vipMap[sVIP.sIP.String()] == 0 {
+					if utils.IsIPHostAddr(sVIP.sIP.String()) {
+						loxinlp.DelAddrNoHook(sVIP.sIP.String()+"/32", "lo")
+					}
+					dev := fmt.Sprintf("llb-rule-%s", sVIP.sIP.String())
+					ret, _ := mh.zr.L3.IfaFind(dev, sVIP.sIP)
+					if ret == 0 {
+						mh.zr.L3.IfaDelete(dev, sVIP.sIP.String()+"/32")
+					}
+					delete(R.vipMap, sVIP.sIP.String())
 				}
-				delete(R.vipMap, sVIP.sIP.String())
 			}
 		}
 	}