Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspaces #64

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Workspaces #64

wants to merge 2 commits into from

Conversation

lishaduck
Copy link
Contributor

@lishaduck lishaduck commented Jun 7, 2024

Deno is rolling out a new feature called workspaces.
It enables JSR monorepos to link to packages locally.
While libs is far less interconnected than deno_std, I figured that it might help if @libs/testing got some extra "tests" by having all the packages link to the local copy in development.

It should also enable a single dependency resolve and (probably) obsolete deno_config.ts, as I believe it automatically syncs formatting/linting/etc.

Copy link
Owner

@lowlighter lowlighter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workspaces setting seems blocked by vercel-community/deno

Everything in .vscode/.github looks good to me so if you'd like to merge these changes now you could open a separate PR

As for the lint.tags I'd prefer keeping it less verbose since it's already the default

bundle/deno.jsonc Outdated Show resolved Hide resolved
deno.jsonc Outdated Show resolved Hide resolved
Copy link
Contributor Author

@lishaduck lishaduck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As for the lint.tags I'd prefer keeping it less verbose since it's already the default

Yeah, I hadn't realized it would make such a big diff when I made the change originally. It's reverted now.

Deno workspaces enable JSR dependencies to resolve to local copies.
This essentially turns all of the packages' tests into tests for `@libs/testing`.
@lishaduck
Copy link
Contributor Author

Ok, it looks like it's not inheriting the fmt and lint configs. I'd assume that CI just needs to get bumped to 1.45.

@lishaduck
Copy link
Contributor Author

Ok, it looks like it's not inheriting the fmt and lint configs. I'd assume that CI just needs to get bumped to 1.45.

Hmm. CI should be using 1.45. Vercel deploys now, which is good. Hmm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants