Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

22 worker class hierarchy needs reworking #35

Merged
merged 3 commits into from
Mar 9, 2025
Merged

22 worker class hierarchy needs reworking #35

merged 3 commits into from
Mar 9, 2025

Conversation

zainaraza43
Copy link
Contributor

  • Added manual DI in Application (we don't quite need to overdo with Factories quite yet)
  • Replaced Workers with Coroutine tasks
  • RabbitMQ functions aren't allowing me to remove the scope in TournamentEngine.processMessage() and StatDaemon.processMessage()
  • Minor name refactors but uncertain about IMatchRepository?? need opinions
  • Tested locally however make sure to test before merging

@zainaraza43 zainaraza43 linked an issue Mar 8, 2025 that may be closed by this pull request
Worker class hierarchy needs reworking #22
Closed
@zainaraza43 zainaraza43 requested a review from ruuffian March 8, 2025 22:52
WahidBawa
WahidBawa approved these changes Mar 9, 2025
View reviewed changes
Copy link

@WahidBawa WahidBawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jere-mie
Copy link

jere-mie commented Mar 9, 2025

Approved! 👍

@ruuffian
Copy link
Contributor

ruuffian commented Mar 9, 2025

@WahidBawa @jere-mie ill merge this without testing or reading if you both reply with your favourite emoji

@jere-mie
Copy link

jere-mie commented Mar 9, 2025

@ruuffian 🇨🇦

ruuffian
ruuffian approved these changes Mar 9, 2025
View reviewed changes
Copy link
Contributor

@ruuffian ruuffian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merged :-)

@WahidBawa
Copy link

@WahidBawa @jere-mie ill merge this without testing or reading if you both reply with your favourite emoji

🌭

@ruuffian ruuffian merged commit 5763dec into main Mar 9, 2025
@jere-mie
Copy link

jere-mie commented Mar 9, 2025

giphy.gif

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WahidBawa WahidBawa WahidBawa approved these changes

@jere-mie jere-mie jere-mie approved these changes

@ruuffian ruuffian ruuffian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Worker class hierarchy needs reworking
4 participants
@zainaraza43 @jere-mie @ruuffian @WahidBawa