[alert_handler,rtl] Fix esc_ping_en widening cast #26380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esc_ping_en is a N_ESC_SEV-wide one-hot signal that is shifted by esc_cnt, which can go up to 3. As a-will observes in lowRISC#22568 (comment), the too-narrow cast didn't cause a problem because the LHS causes us to widen again to N_ESC_SEV anyway. Signed-off-by: Quan Nguyen <[email protected]>
rswarbrick
reviewed
Feb 20, 2025
Signed-off-by: Quan Nguyen <[email protected]>
|
Thank you for the prompt review! And, d'oh, thanks for the nudge to regenerate. |
|
CHANGE AUTHORIZED: hw/top_earlgrey/ip_autogen/alert_handler/rtl/alert_handler_ping_timer.sv No functional change occurs to earlgrey. This is a fixup to an inert cast to make the RHS have the correct width without relying on being the final expression before an assignment. |
|
CHANGE AUTHORIZED: hw/top_earlgrey/ip_autogen/alert_handler/rtl/alert_handler_ping_timer.sv A bugfix in a mistake in my code which (very conveniently) didn't actually break anything: thanks for the analysis. But it looked silly and this is going to do the same thing but less mysteriously! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caught this with Verilator linting -- esc_ping_en is a N_ESC_SEV-wide (currently 4) one-hot signal that is shifted by esc_cnt (which goes up to 3). As a-will observes in #22568 (comment), the too-narrow cast didn't cause a problem because the LHS causes us to widen again to N_ESC_SEV anyway.