[racl] Add generic RACL testplan #26326
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robert Schilling <[email protected]>
Razer6
requested review from
marnovandermaas,
rswarbrick,
andreaskurth,
alees24 and
martin-velay
and removed request for
a team
| { | ||
| name: racl_rw | ||
| desc: ''' | ||
| Precondiiton: |
| desc: ''' | ||
| Precondiiton: | ||
| - Randomize the number of RACL policies and randomize its default policy values. | ||
| - Randomoize the policy selection vector of the CSRs. |
There was a problem hiding this comment.
Nit: "randomize" typo
| - error_log_o.racl_role = <role that caused the error> | ||
| - error_log_o.ctn_uid = <ctn uid that caused the error> | ||
|
|
||
| Verify that a write did not show any effect. |
There was a problem hiding this comment.
I'd say (if that's what you meant):
"Verify that a write has no effect."
| - error_log_o.ctn_uid = <ctn uid that caused the error> | ||
|
|
||
| Verify that a write did not show any effect. | ||
| Verify a read returns all 1 |
There was a problem hiding this comment.
I am not sure I understand what you mean here. Can you elaborate a bit the description?
Nit: and missing "." ponctuation
| - Loop through each CSR and perform a read and write request of using a | ||
| random RACL role and random CTN UID value. | ||
| If the request is allowed: | ||
| * No TL-UL error is expected |
There was a problem hiding this comment.
Is there a reason for this "*"?
| If the request is allowed: | ||
| * No TL-UL error is expected | ||
| else if the request is denied | ||
| Verify the error log matches: |
There was a problem hiding this comment.
If I understand well, if the request is allowed there are 4 main points:
- Verify the error log matches:
- Verify that a write did not show any effect.
- Verify a read returns all 1
- If ErrorRsp = 1:
If yes, can you remove the line jump line 26, and add dashes before to make it more obvious that it's a list of 4 things.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be implement generically and being added to all IPs that support RACL.