Added option to @Everyone in DingTalk notification method #4712
Conversation
|
The writing may not be correct. Please help to check. But according to the official DingTalk documentation, the parameters and fields are correct. Thank you very much. |
| @@ -6,11 +6,14 @@ | |||
| <label for="secretKey" class="form-label">{{ $t("SecretKey") }}<span style="color: red;"><sup>*</sup></span></label> | |||
| <input id="secretKey" v-model="$parent.notification.secretKey" type="text" class="form-control" required> | |||
|
|
|||
| <label for="isAtAll" class="form-label">{{ $t("isAtAll") }}<span style="color: red;"><sup>*</sup></span></label> | |||
There was a problem hiding this comment.
Please change this to a selection box with the options Don't mention people, Notify <code>@everyone</code> (see https://vue-i18n.intlify.dev/guide/advanced/component.html)
With a selection box, implemneting things like @userId is possible (=> "future-proof")
This comment was marked as resolved.
This comment was marked as resolved.
Bumps [undici](https://github.com/nodejs/undici) from 5.28.3 to 5.28.4. - [Release notes](https://github.com/nodejs/undici/releases) - [Commits](nodejs/undici@v5.28.3...v5.28.4) --- updated-dependencies: - dependency-name: undici dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
….28.4 Bump undici from 5.28.3 to 5.28.4
|
What else needs to be adjusted? |
There was a problem hiding this comment.
I think there was some misunderstanding what I meant in #4712 (comment)
Could you add the screenshots of the notification provider working as intended to ensure that this works as intended? ^^
| <label for="isAtAll" class="form-label">{{ $t("isAtAll") }}<span style="color: red;"><sup>*</sup></span></label> | ||
| <select id="isAtAll" v-model="$parent.notification.isAtAll" class="form-select" required> | ||
| <option value="false">{{ $t("false") }}</option> | ||
| <option value="true">{{ $t("true") }}</option> | ||
| </select> |
There was a problem hiding this comment.
What I meant was something like this, but
- with the respective translations in
en.json, - the respective changes to
dingding.jsand - testing that I did not make a typo in the github webeditor ^^^
What do you think about the label? Is this self-explaiantory enough? Do we need to add an helptext? (would not know what to put there, but still would like to have your oppinon on this one)
| <label for="isAtAll" class="form-label">{{ $t("isAtAll") }}<span style="color: red;"><sup>*</sup></span></label> | |
| <select id="isAtAll" v-model="$parent.notification.isAtAll" class="form-select" required> | |
| <option value="false">{{ $t("false") }}</option> | |
| <option value="true">{{ $t("true") }}</option> | |
| </select> | |
| <label for="metioning" class="form-label">{{ $t("Mentioning") }}<span style="color: red;"><sup>*</sup></span></label> | |
| <select id="metioning" v-model="$parent.notification.metioning" class="form-select" required> | |
| <option value="nobody">{{ $t("Don't mention people") }}</option> | |
| <i18n-t keypath="Notify everyone" tag="option" value="@everyone"> | |
| <code>@everyone</code> | |
| </i18n-t> | |
| </select> |
| "isAtAll":"是否通知所有人", | ||
| "true":"是", | ||
| "false":"否", |
There was a problem hiding this comment.
To prevent merge conflicts with weblate (more painfull than worth it), we only allow adding translation keys in en.json.
Please translate this after the PR is merged on weblate.kuma.pet
| "isAtAll":"是否通知所有人", | |
| "true":"是", | |
| "false":"否", |
|
? |
I feel that I have changed the problem, intend to re-comb the next, and then re-submit, thank you very much for your support! |
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma
Tick the checkbox if you understand [x]:
Description
Added option to @everyone in DingTalk notification method
Type of change
Please delete any options that are not relevant.
Checklist
Screenshots (if any)
Please do not use any external image service. Instead, just paste in or drag and drop the image here, and it will be uploaded automatically.