refactor: simplify nusb compilation guards #56
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
louib
force-pushed
the
simplify-nusb-feature-flags
branch
from
951c1e5
to
ebaca45
Compare
|
@droidmonkey I'm going to leave this one in draft mode for now since I'm not really comfortable with the fact that the crate no longer builds when all the features are enabled. I think to fix the feature flag issue, I'm going to introduce a |
|
That's a good approach too, kind of some of the things we wrestled with in my "simplified defaults" build cleanup. |
|
Closing in favor of #57 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.