Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: src_img_root was overwritten from loris2.conf #13

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

tvanbeek
Copy link

For more info see discussion here: #9

@tvanbeek
Copy link
Author

@eliotjordan @jpstroop

@jpstroop
Copy link
Member

@tvanbeek I'm not sure how actively this is maintained anymore. @eliotjordan @bcail @alexwlchan ?

@alexwlchan
Copy link

I'm still around and using Loris – and I’ve seen @bcail merging patches too. Are you talking about this Docker image as unmaintained?

A lot of this looks to be copied from core Loris, I wonder if it’d be worth rethinking it more than patching this one issue? I can have a dig into this properly soon, possibly after Christmas.

@tvanbeek
Copy link
Author

@tvanbeek I'm not sure how actively this is maintained anymore. @eliotjordan @bcail @alexwlchan ?

Whats the best alternative in your opinion? Other then this little thing, which took some time to figure out, its pretty easy to set up.

@jpstroop
Copy link
Member

My apologies, yes I'm talking specifically about this Docker image

@bcail
Copy link
Contributor

bcail commented Dec 19, 2019

I agree with @alexwlchan - that's a lot of code copied over from Loris core, and therefore missing any improvements that are made there. I would suggest updating the docker image to not have its own copy of webapp.py.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants