Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(html): avoid rendering [Object object] for undefined values in Handlebars template #445

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

KalleV
Copy link
Contributor

@KalleV KalleV commented Oct 22, 2024

Description

Avoid rendering undefined/null values from errors as [Object object] in the HTML output.

Related issues

Checklist

  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style
    guide

@KalleV KalleV force-pushed the kallev_fix_html_rendering branch 2 times, most recently from b250522 to 63e235c Compare October 23, 2024 13:48
@KalleV KalleV changed the title fix(html): avoid rendering [Object object] for undefined values fix(html): avoid rendering [Object object] for undefined values in HTML template Oct 23, 2024
@KalleV KalleV changed the title fix(html): avoid rendering [Object object] for undefined values in HTML template fix(html): avoid rendering [Object object] for undefined values in Handlebars template Oct 23, 2024
@KalleV KalleV marked this pull request as ready for review October 23, 2024 14:05
Copy link
Member

@achrinza achrinza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for identifying and creating a fix.

Everything LGTM 👍

@achrinza achrinza merged commit 972d410 into loopbackio:master Oct 23, 2024
12 checks passed
@KalleV KalleV deleted the kallev_fix_html_rendering branch October 23, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression in HTML rendering for properties with undefined values
2 participants